Closed Bug 1608314 Opened 3 months ago Closed 3 months ago

Port bug 1606869: Remove cache scopes that lack trust domain prefix.

Categories

(Thunderbird :: Build Config, task)

task
Not set

Tracking

(thunderbird_esr68 fixed, thunderbird73 fixed)

RESOLVED FIXED
Thunderbird 74.0
Tracking Status
thunderbird_esr68 --- fixed
thunderbird73 --- fixed

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1606869 +++

Assignee: nobody → rob
Attached patch bug1608314.patchSplinter Review
Try job works.
Attachment #9119937 - Flags: review?(geoff)
Comment on attachment 9119937 [details] [diff] [review]
bug1608314.patch

[Approval Request Comment]
Tom is waiting on us to finish his work. The corresponding change has landed in m-beta.
https://hg.mozilla.org/releases/mozilla-beta/rev/112acf1589255226c77a24f459c165d136de921c
Attachment #9119937 - Flags: approval-comm-beta?

This also needs to go on c-esr68. Formal request is coming as it won't apply without other uplifts.

Attachment #9119937 - Flags: review?(geoff) → review+
Comment on attachment 9119937 [details] [diff] [review]
bug1608314.patch

For c-esr68, there are two additional patches that need to go first. The first is on bug 1504004, the second Geoff landed with a no-bug.

Commit hashes on c-c for those are:
Bug 1504004: aac1db8eb71e685030659b70847fac4c50e3b105
No bug (whitespace fix): 50d6adde4a6c28a673d923a658dac8bc4929db37

I'll run a try build as soon as I can to make sure, but it should be fine.
Attachment #9119937 - Flags: approval-comm-esr68?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/ac3819169b50
Port bug 1606869: Prefix decision task scope with comm trust domain. r=darktrojan

Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0
Attachment #9119937 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #9119937 - Flags: approval-comm-esr68? → approval-comm-esr68+

Rebased on top of attachment 9122771 [details] [diff] [review] for comm-esr68.
The white space patches are folded in.

Attachment #9122772 - Flags: approval-comm-esr68?

Including this for reference.

The backouts in rev 0b0b3a9db37babf98482db1c0abf0abf43b5ca29 were necessary because of a difference in how parameters are passed to action tasks between comm-central and comm-esr68. It's necessary to include the parameters in .taskcluster.yml on comm-esr68 as can be seen in the version in m-esr68.

Attachment #9122772 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.