1608314 - Port bug 1606869: Remove cache scopes that lack trust domain prefix.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

+++ This bug was initially created as a clone of Bug #1606869 +++

Comment 1

[Rob Lemley [:rjl]]

Attachment: bug1608314.patch

Try job works.

Comment 2

[Rob Lemley [:rjl]]

Comment on attachment 9119937 [details] [diff] [review]
bug1608314.patch

[Approval Request Comment]
Tom is waiting on us to finish his work. The corresponding change has landed in m-beta.
https://hg.mozilla.org/releases/mozilla-beta/rev/112acf1589255226c77a24f459c165d136de921c

Comment 3

[Rob Lemley [:rjl]]

This also needs to go on c-esr68. Formal request is coming as it won't apply without other uplifts.

Comment 4

[Rob Lemley [:rjl]]

Comment on attachment 9119937 [details] [diff] [review]
bug1608314.patch

For c-esr68, there are two additional patches that need to go first. The first is on bug 1504004, the second Geoff landed with a no-bug.

Commit hashes on c-c for those are:
Bug 1504004: aac1db8eb71e685030659b70847fac4c50e3b105
No bug (whitespace fix): 50d6adde4a6c28a673d923a658dac8bc4929db37

I'll run a try build as soon as I can to make sure, but it should be fine.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ac3819169b50
Port bug 1606869: Prefix decision task scope with comm trust domain. r=darktrojan

Comment 6

[Geoff Lankow (:darktrojan)]

73 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/58449de9c7ce74770103e0b101bc3846f6aa5cc4

Comment 7

[Geoff Lankow (:darktrojan)]

68.4.2:
https://hg.mozilla.org/releases/comm-esr68/rev/be3eb5374df9d02d05d29d00de426cc7ec3331ea

Comment 8

[Rob Lemley [:rjl]]

Attachment: bug1608314_comm-esr68.patch

Rebased on top of attachment 9122771 [details] [diff] [review] for comm-esr68.
The white space patches are folded in.

Comment 9

[Rob Lemley [:rjl]]

Attachment: tcyml_diff_to_broken.patch

Including this for reference.

The backouts in rev 0b0b3a9db37babf98482db1c0abf0abf43b5ca29 were necessary because of a difference in how parameters are passed to action tasks between comm-central and comm-esr68. It's necessary to include the parameters in .taskcluster.yml on comm-esr68 as can be seen in the version in m-esr68.

Comment 10

[Rob Lemley [:rjl]]

https://hg.mozilla.org/releases/comm-esr68/rev/e706b20531638432f9f6330a4b73731d04916e72