Closed Bug 1608334 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21123 - [WPT/common/security-features] Move per-project config into spec.src.json

Categories

(Core :: DOM: Security, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Sync web-platform-tests PR 21123 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21123
Details from upstream follow.

Hiroshige Hayashizaki <hiroshige@chromium.org> wrote:

[WPT/common/security-features] Move per-project config into spec.src.json

[1] will enable sub projects inheriting parent's spec.src.json,
in order to generate similar but subtlely different tests.
As a preparation for [1],
this CL centralizes per-project configs into spec.src.json,
by moving config values from per-project generate.py into spec.src.json.

  • spec_directory is now the current directory,
    or specified by the --spec command line option,
    while previously it is calculated based on the per-project generate.py's path.
  • Script paths (helper_js, sanity_checker_js, spec_json_js) are now hard-coded
    (using spec_directory) in common/security-features/tools/generate.py.
  • Other config values are moved into spec.src.json.
  • spec_json.js is moved under generic/, to a little centralize
    generator-related files into generic/.

Generated files are affected because:

  • Scripts (like test-case.sub.js) are now referenced as relative paths
    from generated test HTMLs.
  • disclaimer.template is updated.

Generated files will be updated in a separate CL [2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1991066/
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1992955/

Bug: 906850
Change-Id: Id3b2a26b67296a1de2b682e07bdcf473f666cd25

Reviewed-on: https://chromium-review.googlesource.com/1989718
WPT-Export-Revision: 8f6977e3c0b29bcedf14bd165aeaa8e87bd3795a

Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/888730e8fbcc
[wpt PR 21123] - [WPT/common/security-features] Move per-project config into spec.src.json, a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.