1608336 - Touch bar icons missing when only non-browser windows open

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Sam Johnson]

Attachment: Touch Bar Shot 2020-01-10 at 1.37.55 AM.png

The icons in the macOS touch bar are missing (but text and buttons are still visible) if there is a Firefox window focused, but no browser window open.

STR:

• Launch Firefox on a touch bar-equipped machine.
• Close the browser window, then open either the About or Library windows.
• Observe touch bar buttons are visible but missing their icons (example screenshot attached).

Expected: Either the touch bar buttons themselves should not be present in this scenario, or they should be visible but with a disabled appearance.

System:
macOS 10.15.2
MacBook Pro (15-inch, 2018)
Nightly 74.0a1 (2020-01-09) (64-bit)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:spohl, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Harry Twyford]

Attachment: Bug 1608336 - Disable Touch Bar for non-chrome windows. r?mikedeboer

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28f5f9a91199
Disable Touch Bar for non-chrome windows. r=mikedeboer

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/28f5f9a91199

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is this something we should nominate for Beta uplift to ship in 74?

Comment 6

[Harry Twyford]

I'd first like to wait a few days to look out for regressions, although this wasn't a very significant patch so it should be fine. I'll leave ni? to remind myself to check back.

Comment 7

[Harry Twyford]

Comment on attachment 9125484 [details]
Bug 1608336 - Disable Touch Bar for non-chrome windows. r?mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: UI ugliness: the Touch Bar contains unlabelled and useless buttons under the conditions in comment 0.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a null-check to disable Touch Bar behaviour in some contexts. No chance of spillover effects into non-Touch Bar components, and the Touch Bar is seen by a very small proportion of users.
• String changes made/needed:

Comment 8

[Cristian Fogel [:cfogel]]

Reproduced issue with the following setup:
macOS 10.15.3 / Nightly 74.0a1 (2020-01-08) (64-bit).

Fix verified with 75.0a1 (2020-02-16).

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9125484 [details]
Bug 1608336 - Disable Touch Bar for non-chrome windows. r?mikedeboer

Low risk patch, verified on Nightly, uplift approved for 74?0b5, thanks.

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/24c0f5e578cb

Comment 11

[Cristian Fogel [:cfogel]]

Fix verified with 74.0b5 on macOS 10.15.3.
"unlabelled and useless buttons" are not displayed.