If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[FIX]Create objects in the CSSOM for @charset rules

VERIFIED FIXED in mozilla1.2alpha

Status

()

Core
CSS Parsing and Computation
P1
normal
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

({testcase})

Trunk
mozilla1.2alpha
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

We should really create CSSCharsetRule objects in the CSSOM for @charset rules...
Blocks: 35617
Created attachment 93839 [details] [diff] [review]
This does the job
Priority: -- → P1
Summary: Create objects in the CSSOM for @charset rules → [FIX]Create objects in the CSSOM for @charset rules
Target Milestone: --- → mozilla1.2alpha
Comment on attachment 93839 [details] [diff] [review]
This does the job

r=glazman
goooooooooood
Attachment #93839 - Flags: review+
Comment on attachment 93839 [details] [diff] [review]
This does the job

Why not just remove the nsICSSCharsetRule interface completely?
I considered doing that.... I'm not sure whether we'll want to re-introduce it
at some point, though. Will we ever want to do things with charset rules that
are not doable via the CSSOM and the nsICSSRule interface?
Considering the amount we've done with @charset rules so far, I doubt it.
Created attachment 93915 [details] [diff] [review]
Out, out, nsICSSCharsetRule!
Attachment #93839 - Attachment is obsolete: true
Comment on attachment 93915 [details] [diff] [review]
Out, out, nsICSSCharsetRule!

sr=dbaron.

(I was thinking nsCSSRule inherited from nsICSSRule.  Is there any reason it
doesn't?)
Attachment #93915 - Flags: superreview+
Created attachment 93922 [details]
testcase to make sure things are all happy
fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 10

15 years ago
verified 
Status: RESOLVED → VERIFIED
Keywords: testcase
You need to log in before you can comment on or make changes to this bug.