Closed Bug 1608359 Opened 11 months ago Closed 11 months ago

Don't open TopSites on focus if top sites are hidden in the new tab page

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 74
Iteration:
74.1 - Jan 6 - Jan 19
Tracking Status
firefox74 --- verified
firefox75 --- verified

People

(Reporter: mak, Assigned: harry)

References

Details

(Keywords: privacy)

Attachments

(1 file)

For users hiding top sites in the new tab page, we should not automatically open the Top Sites dropdown on focus.

Also consider browser.newtabpage.enabled = false and browser.startup.homepage = about:blank (both exposed in about:preferences) effectively hides Top Sites as well.

We'll surely evaluate those, but we don't want to go too far away with detection, to avoid false positives (users unconsciously cutting themselves out of top sites). Disabling top sites in the new tab page is a very clear and conscious decision by the user.

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Type: task → enhancement
Iteration: --- → 74.1 - Jan 6 - Jan 19
Points: 3 → 2
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
Depends on: 1606069
Assignee: dao+bmo → htwyford
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c14fae819be7
Don't open TopSites on focus if top sites are hidden in the new tab page. r=dao
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Flags: qe-verify+
QA Contact: cristian.comorasu

I can confirm this behavior is respected. I verified using Fx 75.0a1 (2020-02-03), Fx 74.0b2 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 LTS.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Blocks: 1616793
No longer blocks: 1616793
Regressions: 1616793
You need to log in before you can comment on or make changes to this bug.