1608383 - Ctrl-Shift-Z in bookmarks sidebar opens debugger instead of redoing changes

Status: NEW

(DevTools :: Debugger, defect, P3)

Description

[greselin.andrea]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Example with duplicating a bookmark (*): open the Bookmarks sidebar (Ctrl-B), select a bookmark there, copy and paste it (Ctrl-C, Ctrl-V), undo (Ctrl-Z) -- the duplicate is removed. Now press Ctrl-Shift-Z.

Actual results:

The developer tools debugger opens.

• The kind of operation on bookmarks (copy, delete, move, etc.) is irrelevant. Pressing Ctrl-Shift-Z after undoing the operation always brings up the debugger.

Expected results:

The duplicate bookmark should have been brought back (undoing the undo). (That's how it worked in previous versions; I can't tell exactly which, but I believe at least until v. 70.)

Comment 1

[Gingerbread Man]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fd648a1bcdcf029847452ea045ffb560564b5890&tochange=abe56cdae49dbf0e188758d1744071a141c9e8a9

On Windows, I can't find a working shortcut for the Debugger:

• Ctrl+Shift+Z is what the menus and tooltips show. It doesn't work.
• Ctrl+Shift+S is what the documentation shows. It doesn't work.
• Ctrl+Shift+L was the old shortcut. It was removed.

Comment 2

[David Walsh :davidwalsh]

I can confirm. :harald, what do we want to do here? I don't think we have the ability to "contain" this shortcut for individual panels being opened. It's sort of an all-or-nothing with these type of shortcuts.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Gingerbread Man from comment #1)

On Windows, I can't find a working shortcut for the Debugger:

• Ctrl+Shift+Z is what the menus and tooltips show. It doesn't work.
• Ctrl+Shift+S is what the documentation shows. It doesn't

Also this doc is wrong:
https://mozilladevelopers.github.io/playground/debugger/
See also bug 1599945

Honza

Comment 4

[:Harald Kirschner :digitarald]

This bug is about Ctrl-Shift-Z not working to undo in bookmarks though, correct? It seems that bookmark editor could catch that shortcut and correctly prevents the default.

Comment 5

[Gingerbread Man]

(In reply to :Harald Kirschner :digitarald from comment #4)

This bug is about Ctrl-Shift-Z not working to undo in bookmarks though, correct?

As I said at comment 1, there's no working Debugger shortcut (at least on Windows).

Comment 6

[:Harald Kirschner :digitarald]

As I said at comment 1, there's no working Debugger shortcut (at least on Windows).

I can reproduce your comment. But that would be a separate bug then if I understand the initial bug report correctly – so I filed bug 1617765.

Comment 7

[jd01752]

Just wanted to add that debugger panel also pops up/ takes focus when trying to ctrl-shift-z redo from various areas of the devoloper tools but only when in separate window undocked mode. It does achieve the redo but also sends focus to debug panel. Both Linux and Windows.
Also curious if there's anything special about choosing z for debug shortcut. Would a choice of a different available letter be a quick fix? Or are people too used to that debug shortcut to change it now?