1608425 - The picture-in-picture button is hidden beneath other buttons that are present on the page on twitch.tv

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Oana Botisan, Desktop QA]

Attachment: Screenshsfewfqot_1.png

Affected versions

• Firefox 73.0b1
• Nightly 74.0a1

Affected platforms

• Windows 10 x64
• Windows 7 x86
• Ubuntu 18.04 x64
• macOS 10.13

Steps to reproduce

1. Go to twitch.tv.
2. Click on a video to watch it.
3. Search for the PiP button.

Expected result

• The button can be seen easily.

Actual result

• The button is hidden behind the scrollbar and other buttons that are present on the page.

Regression range

• I don't think this is a regression, I can reproduce the issue on builds from 2019-04-20.

Additional notes

• It doesn't matter if you resize the window, the button is still hidden.
• Please look at the attached image.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1608425 - Adjust Picture-in-Picture toggle to be at 25% from the top for Twitch videos. r?denschub

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b25fed24cf8f
Adjust Picture-in-Picture toggle to be at 25% from the top for Twitch videos. r=denschub

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:mconley, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b25fed24cf8f

Comment 6

[abodenlosz]

Issue is no longer reproducible i.e. the pip button is moved to 25% from the top of the video.

• Additional note: on live streaming videos the pip button is not functional in case there is a semitransparent iframe.

Comment 7

[Maria Berlinger [:mberlinger], Services QA]

I've managed to reproduce this issue on Firefox 74.0a1 (2020-01-10) using Windows 10x64 by following the STR from comment 0.
This issue is verified fixed on Firefox 74.0b6 and Firefox 75.0a1 (2020-02-21) on the following OSes: Windows 10x64, Windows 7x64, macOS 10.15 and Ubuntu 18.04x64.