1608449 - Disable LSNG in 73

Status: VERIFIED FIXED

(Core :: Storage: localStorage & sessionStorage, task, P1)

Description

[Jan Varga [:janv]]

We can't ship it on Release until storage initialization failures are addressed.

There seems to be one failing test currently:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c47f30849bb0db8950360149b311756f2b918fb7

Comment 1

[Pascal Chevrel:pascalc]

Jan, would it be possible to have a beta patch to disable LSNG before the allhands? Thanks

Comment 2

[Jan Varga [:janv]]

Yeah, working on it. There's one test that is failing with LSNG disabled.

Comment 3

[Jan Varga [:janv]]

Testing mozilla-central:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52eb0cec7ba8e7306b2ce7f04e389a483b011170

Testing mozilla-beta:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=90a97ed47afc84336b085916293dde7953c1503f

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1608449 - Disable LSNG in 73; r=asuth

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1608449 - Test fixes for old localStorage implementation; r=asuth

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 9122736 [details]
Bug 1608449 - Disable LSNG in 73; r=asuth

Beta/Release Uplift Approval Request

• User impact if declined: If LSNG is enabled, LocalStorage depends on QuotaManager storage which is currently broken for some users. We don't want to ship LSNG until the issue is fixed.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch just disables LSNG, so the old implementation of LocalStorage will be used in FF 72. We fully support downgrading of LocalStorage data, so if some users already tried a beta build, they should be safe. We disabled LSNG in previous beta cycles and there were no problems reported after the switch.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9122737 [details]
Bug 1608449 - Test fixes for old localStorage implementation; r=asuth

IIUC, D60883 includes these changes already. This is just needed for trunk.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9122736 [details]
Bug 1608449 - Disable LSNG in 73; r=asuth

Approved for 73.0b9.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/25e854c968684e49838c9048bfb6d66222945914

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f73bfe55131b
Test fixes for old localStorage implementation; r=asuth

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f73bfe55131b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

We should have QA verify this.

Comment 13

[Cristian Fogel [:cfogel]]

Patch verified with:

• Windows 10 with 73.0, 74.0a1(2020-02-02;
• Ubuntu 19.04 with 73.0b11, 74.0a1(2020-02-04);
• macOS 10.13.6 with 73.0b12, 74.0a1(2020-02-03);

Comment 14

[Stefan Deiac]

Hello, I verified that this issue is fixed using the latest version of Firefox Preview Nightly 2/4 #20350605 and Firefox Preview Beta 3.2.0-beta.3.

Devices:

• Samsung Galaxy Note 8 (Android 9);
• Motorola Moto G6 (Android 8).