1608458 - [Automated review] figure out how to handle js/src/gdb/tests

Status: NEW

(Developer Infrastructure :: Source Code Analysis, task, P3)

Description

[Jason Orendorff [:jorendorff]]

Here are the interesting points about the code in js/src/gdb/tests:

• this is itself a test, not something that needs test coverage (or needs to be deleted)

• yes it's useful code we want to keep

• it's not built into any shipping product

• it's testing GDB scripts that are only relevant to Mozilla developers working on the JS engine on Linux

• the test requires GDB to be installed, so I don't know what it would take to run the test in infra

• it's actually OK if these tests are failing; fixing the GDB scripts is low-priority and we do not want to bounce patches for breaking them

I really don't know what to do with this. I'd be OK with just silencing the warning, if there's a suitable whitelist somewhere.

Phabricator URL: https://phabricator.services.mozilla.com/D59361

Comment 1

[Jason Orendorff [:jorendorff]]

Huh. It looks like bug 1597005 added a task for this a couple months ago, so I don't know why the warning is still there.