Closed Bug 1608468 Opened 6 years ago Closed 2 years ago

Add support for "mobile" and "screenOrientation" property of Emulation.setDeviceMetricsOverride

Categories

(Remote Protocol :: CDP, task, P3)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: whimboo, Unassigned)

References

Details

Right now we don't build the Remote Agent for mobile, and as such the basic implementation as done on bug 1588432 will not support mobile. Behavior to implement will be for:

  • mobile (docShell.deviceSizeIsPageSize)
  • screenOrientation (Marionette uses window.screen.mozOrientation)
  • touch emulation (maybe related to bug 1605784)

When working on this bug make sure to run the emulation.spec.js test from Puppeteer.

Blocks: 1602926
Blocks: 1610285

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #0)

This is done now and works pretty fine.

  • mobile (docShell.deviceSizeIsPageSize)
  • screenOrientation (Marionette uses window.screen.mozOrientation)

That means those to two are remaining now

Summary: Add mobile support to Emulation.setDeviceMetricsOverride → Add support for "mobile" and "screenOrientation" property of Emulation.setDeviceMetricsOverride
Component: CDP: Emulation → CDP
Severity: normal → S3

We are not going to implement these arguments for CDP but will have it eventually for WebDriver BiDi.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.