Closed Bug 1608509 Opened 1 month ago Closed 1 month ago

Switch from JSOP_* to JSOp::*

Categories

(Core :: JavaScript Engine, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(9 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

A massive find/replace.

The comment about JSOP_GLOBALTHIS and JSOP_FUNCTIONTHIS may never have been
sensible; JSOP_FUNCTIONTHIS never walks the environment chain, as it is used
only in non-arrow functions, which take this as an argument in the CallArgs.

JSOP_LOOPENTRY and JSOP_TRACE are gone. So is JSOP_SPREAD.

"JSOP_POPs" was eccentric in a way that would be unclear with CamelCase.

Assignee: nobody → jorendorff
Status: NEW → ASSIGNED

This also removes the name field from FOR_EACH_OPCODE. Disassembly now uses
the UpperCamelCase opcode name.

A few tests look at disassembler output.

Depends on D59808

Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/725809d9e561
Part 1: Fix a few odd comments. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/902789c51843
Part 2: Automated substitution for /\b(JSOP_\w+)\b/ in comments. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/aa570fcbe849
Part 3: Manual fixups in comments. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/8b9140b7fe75
Part 4: More manual fixups in comments. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/7861d659ea07
Part 5: Rename baseline emit methods. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/b1295a6b6345
Part 6: Rename JSOP_*_LENGTH constants. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/ded7d57dfd7f
Part 7: Automatically replace JSOP_UPPER with JSOp::CamelCase. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/378627d9d058
Part 8: Remove JSOP_* constants. r=jandem.
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9cc637fda6e0
Backed out 3 changesets for bustages on Interpreter.cpp. CLOSED TREE
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa08ba115ada
Part 6: Rename JSOP_*_LENGTH constants. r=jandem.
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/199ff346e675
Part 7: Automatically replace JSOP_UPPER with JSOp::CamelCase. r=jandem.
https://hg.mozilla.org/integration/autoland/rev/ec5d11f7e545
Part 8: Remove JSOP_* constants. r=jandem.
You need to log in before you can comment on or make changes to this bug.