1608577 - Get rid of "using namespace mozilla::java" in Gecko

Status: RESOLVED FIXED

(Core :: General, task, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

https://searchfox.org/mozilla-central/search?q=using+namespace.*java%3B&case=false&regexp=true&path=

This is bad, as it makes it so that GV can't declare types in Java-land with identical names to their C++ analogs because, even though we generate the JNI stuff in a separate namespace, people are importing all that stuff into their source.

This is particularly bad because we currently dump all generated JNI wrappers into a single giant header file.

Also, there's even a using namespace inside a header file, which is double-bad.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1608577: Part 1 - Remove |using namespace mozilla::java| from dom/media; r=kinetik

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1608577: Part 2 - Remove |using namespace mozilla::java| from webrtc; r=bwc

Depends on D59796

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1608577: Part 3 - Remove |using namespace mozilla::java| from widget/android; r=#geckoview-reviewers

Depends on D59797

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00ea3cdf6e19
Part 1 - Remove |using namespace mozilla::java| from dom/media; r=kinetik
https://hg.mozilla.org/integration/autoland/rev/158cbeb17bba
Part 2 - Remove |using namespace mozilla::java| from webrtc; r=bwc
https://hg.mozilla.org/integration/autoland/rev/9f5fb892f32c
Part 3 - Remove |using namespace mozilla::java| from widget/android; r=geckoview-reviewers,esawin

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/00ea3cdf6e19
https://hg.mozilla.org/mozilla-central/rev/158cbeb17bba
https://hg.mozilla.org/mozilla-central/rev/9f5fb892f32c