Closed Bug 1608658 Opened 4 years ago Closed 4 years ago

AutocompleteInput.detachController() should consider null element.mController

Categories

(Toolkit :: Autocomplete, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(1 file)

In Thunderbird test automation we got some errors from detachController that element.mController.input is null when (Thunderbird) code calls detachController()
https://searchfox.org/comm-central/rev/031a80891c663aa0304daac890c20cc789ef01ca/mail/components/compose/content/addressingWidgetOverlay.js#486

While this is worked around with the if (element.mController.input) check, looks like that should be handled by the autocomplete widget.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/integration/autoland/rev/4f5763919484
AutocompleteInput.detachController() should consider null element.mController. r=mak
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: