1608745 - Repetitive code in ProcessCrlDistPoints

Status: RESOLVED WONTFIX

(Core :: Security: PSM, task)

Description

[Alex Henrie]

Since before the switch to Mercurial in 2007, ProcessCrlDistPoints has had (with minor changes) the following lengthy and repetitive chunk of code:

  bool comma = false;
  if (reasons & RF_UNUSED) {
    GetPIPNSSBundleString("CertDumpUnused", local);
    text.Append(local);
    comma = true;
  }
  if (reasons & RF_KEY_COMPROMISE) {
    if (comma) text.AppendLiteral(", ");
    GetPIPNSSBundleString("CertDumpKeyCompromise", local);
    text.Append(local);
    comma = true;
  }
  if (reasons & RF_CA_COMPROMISE) {
    if (comma) text.AppendLiteral(", ");
    GetPIPNSSBundleString("CertDumpCACompromise", local);
    text.Append(local);
    comma = true;
  }
  if (reasons & RF_AFFILIATION_CHANGED) {
    if (comma) text.AppendLiteral(", ");
    GetPIPNSSBundleString("CertDumpAffiliationChanged", local);
    text.Append(local);
    comma = true;
  }
  if (reasons & RF_SUPERSEDED) {
    if (comma) text.AppendLiteral(", ");
    GetPIPNSSBundleString("CertDumpSuperseded", local);
    text.Append(local);
    comma = true;
  }
  if (reasons & RF_CESSATION_OF_OPERATION) {
    if (comma) text.AppendLiteral(", ");
    GetPIPNSSBundleString("CertDumpCessation", local);
    text.Append(local);
    comma = true;
  }
  if (reasons & RF_CERTIFICATE_HOLD) {
    if (comma) text.AppendLiteral(", ");
    GetPIPNSSBundleString("CertDumpHold", local);
    text.Append(local);
    comma = true;
  }

This should all be replaced with a loop to improve code readability and performance, and to make refactoring it easier in the future.

Comment 1

[Alex Henrie]

Attachment: Bug 1608745 - Replace repetitive code in ProcessCrlDistPoints with a loop.