Closed Bug 1608746 Opened 4 years ago Closed 4 years ago

Fission crash in [@ NS_GetSanitizedURIStringFromURI]

Categories

(Core :: DOM: Navigation, defect, P1)

Unspecified
All
defect

Tracking

()

RESOLVED DUPLICATE of bug 1574017
Fission Milestone M5

People

(Reporter: cpeterson, Unassigned)

References

(Regression, )

Details

(Keywords: crash, regression, reproducible)

Crash Data

This bug is for crash report bp-4778a50e-1759-4713-bfec-a7bd20200113.

I hit this crash every time I load following URL when I have Fission enabled:

https://onedrive.live.com/about/en-us/plans/

This is not a recent regression. I can reproduce at least as far back as 70 Nightly with Fission enabled.

Top 10 frames of crashing thread:

0 XUL NS_GetSanitizedURIStringFromURI netwerk/base/nsNetUtil.cpp:1902
1 XUL mozilla::dom::PostMessageEvent::Run dom/base/PostMessageEvent.cpp:146
2 XUL mozilla::dom::Document::FireOrClearPostMessageEvents dom/base/Document.cpp:11620
3 XUL mozilla::dom::FireOrClearDelayedEvents dom/base/Document.cpp:11244
4 XUL mozilla::dom::nsDelayedEventDispatcher::Run dom/base/Document.cpp:11542
5 XUL mozilla::SchedulerGroup::Runnable::Run xpcom/threads/SchedulerGroup.cpp:282
6 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1248
7 XUL <name omitted> xpcom/threads/nsThreadUtils.cpp:486
8 XUL mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87
9 XUL MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290

Wasn't Anny looking into some PostMessage issues, perhaps this is related?

@ bhackett, I bisected this crash with mozregression. I think this crash is a regression from your postMessage bug 1124122 (fixed in Firefox 69):

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=19f38c9cdd671aac3fc57ccde19560f337d7d992&tochange=51440617724b12fec25ba05b0b2e25241c92683e

Bug 1124122 is a DevTools bug that appears to be unrelated to Fission. Could this NS_GetSanitizedURIStringFromURI crash affect non-Fission users? I was only able to reproduce this bug with Fission enabled.

I can reproduce on both macOS and Windows.

Flags: needinfo?(bhackett1024)
Keywords: regression
OS: macOS → All
Regressed by: 1124122
Has Regression Range: --- → yes

I was able to reproduce this when I have an existing "https://onedrive.live.com/about/en-us/plans/" already opened in one tab and I open the URL for the second time. I tested this with my fix from bug 1574017 and I didn't see the crash anymore.

I can mark this as being a duplicate of bug 1574017?

Flags: needinfo?(cpeterson)

(In reply to Anny Gakhokidze [:annyG] from comment #4)

I can mark this as being a duplicate of bug 1574017?

I'll go ahead close this bug as a duplicate. Thanks!

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(cpeterson)
Flags: needinfo?(bhackett1024)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.