1608829 - "Learn more" link in the Data Collection section on about:preferences is in a second line instead of the same line

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Itiel]

+++ This bug was initially created as a clone of Bug #1608802 +++

STR:

1. Open about:preferences#privacy
2. Scroll to the Data Collection section, see the "Allow Nightly to send technical and interaction data to Mozilla" checkbox

AR:
"Learn More" link in a new line

ER:
Should be in the same line.

Regressed by bug 1606130.

Comment 1

[:Gijs (he/him)]

Giving the checkbox display: -moz-inline-box fixes this, along the lines of https://phabricator.services.mozilla.com/D59093 .

Emilio, can you help me understand why this checkbox and (as far as I can tell) only this checkbox is affected here, and/or how we'd look for other elements that may have started behaving differently under the circumstances?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Because that checkbox is the only one directly below an HTML block (<description> always has an HTML block layout). The others are inside an hbox or such.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1608829 - fix wrapping of telemetry checkbox in the preferences/options, r?emilio

Comment 4

[:Gijs (he/him)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Because that checkbox is the only one directly below an HTML block (<description> always has an HTML block layout). The others are inside an hbox or such.

OK. I did a quick check, I don't think there are other <checkbox> elements directly inside a <description> in either the prefs or other parts of the codebase, so let's just fix this one checkbox...

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/850151a68fbe
fix wrapping of telemetry checkbox in the preferences/options, r=emilio

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/850151a68fbe

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 8

[:Gijs (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)

Please nominate this for Beta approval when you get a chance.

This bit me in bug 1608802 as well, but I don't think beta is affected? See https://bugzilla.mozilla.org/show_bug.cgi?id=1608802#c7 . We landed https://hg.mozilla.org/integration/autoland/rev/0aa32e6d6d58 in 73, which won't have caused this regression; whereas https://hg.mozilla.org/mozilla-central/rev/be0ddae5d705 did, but only landed in 74. In hindsight, we should have split the bug - sorry, lesson learned...