Closed Bug 1608974 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21150 - Ignore unexpected MessageEvents

Categories

(Core :: DOM: Web Payments, task, P4)

Product:
Core
Component:
DOM: Web Payments
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21150 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21150
Details from upstream follow.

Danyao Wang <danyao@google.com> wrote:

Ignore unexpected MessageEvents

When running these tests in the web runner, extra MessageEvents sometimes appear before the ones generated by the test iframe and causes the test to fail. This patch modifies the test to ignore any messages that are not from the test iframe to improve the consistency of the test.

Component: web-platform-tests → DOM: Web Payments
Product: Testing → Core

CI Results

Ran 18 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

OK : 3
PASS: 39
FAIL: 3

Chrome

OK : 3
PASS: 3

Safari

OK : 3
PASS: 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html
PaymentRequest setting allowpaymentrequest after document creation, before response: FAIL

New Tests That Don't Pass

/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
PaymentRequest setting allowpaymentrequest after load and then navigating: FAIL (Chrome: PASS, Safari: FAIL)
/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
PaymentRequest removing allowpaymentrequest after load and then navigating: FAIL (Chrome: PASS, Safari: FAIL)
/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
PaymentRequest setting allowpaymentrequest after document creation, before response: FAIL (Chrome: PASS, Safari: PASS)

Tests Disabled in Gecko Infrastructure

/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77972c20092a
[wpt PR 21150] - Ignore unexpected MessageEvents, a=testonly

https://hg.mozilla.org/mozilla-central/rev/77972c20092a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.