1608983 - Don't check regexp syntax twice

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Iain Ireland [:iain]]

The JS spec says that syntax errors in regular expressions should be early errors. (V8 doesn't do this, but that's another matter.) To enforce this during both syntax and full parse, we parse the pattern, verify that it parsed correctly, then throw the result away.

At a bare minimum, we shouldn't have to do this twice. If we are full parsing something that has already been syntax parsed, this patch skips the regexp syntax check.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1608983: Don't check regexp syntax in full parse if we've already done so during syntax parse r=arai

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9b4e031bb09
Don't check regexp syntax in full parse if we've already done so during syntax parse r=arai

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f9b4e031bb09