1608999 - [wpt-sync] Sync PR 21151 - [css-grid] Skip simplified layout if the Grid is dirty.

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21151 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21151
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[css-grid] Skip simplified layout if the Grid is dirty.

Bug report bisected to an improvment in the LayoutNG OOF cache.
https://chromium-review.googlesource.com/c/chromium/src/+/1772524

There was a larger underlying issue that a LayoutGrid could have
simplfied layout performed, while having a non-existant grid.

This manifested in an incorrect paint output.

This patch simply disables simplified-layout whenever there is dirty grid.
It doesn't seem the invalidation for this grid data-structure is optimal.

Bug: 1040069
Change-Id: I347630f3fc5c330ae57b06219d1e32b6269177d2
Reviewed-on: https://chromium-review.googlesource.com/1999224
WPT-Export-Revision: 8b69707561f21fe9d59789cf506401349a01c079

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd7eb5dd8a0c25d264055a1ddacf8b195dad4f40

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a980e7ea9d0a
[wpt PR 21151] - [css-grid] Skip simplified layout if the Grid is dirty., a=testonly

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a980e7ea9d0a