Closed Bug 1608999 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 21151 - [css-grid] Skip simplified layout if the Grid is dirty.

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21151 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21151
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[css-grid] Skip simplified layout if the Grid is dirty.

Bug report bisected to an improvment in the LayoutNG OOF cache.
https://chromium-review.googlesource.com/c/chromium/src/+/1772524

There was a larger underlying issue that a LayoutGrid could have
simplfied layout performed, while having a non-existant grid.

This manifested in an incorrect paint output.

This patch simply disables simplified-layout whenever there is dirty grid.
It doesn't seem the invalidation for this grid data-structure is optimal.

Bug: 1040069
Change-Id: I347630f3fc5c330ae57b06219d1e32b6269177d2
Reviewed-on: https://chromium-review.googlesource.com/1999224
WPT-Export-Revision: 8b69707561f21fe9d59789cf506401349a01c079

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a980e7ea9d0a
[wpt PR 21151] - [css-grid] Skip simplified layout if the Grid is dirty., a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.