Closed Bug 1609003 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 21152 - [css-pseudo] Implement LayoutNG normal markers as real pseudo-elements

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21152 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21152
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-pseudo] Implement LayoutNG normal markers as real pseudo-elements

Before this patch, list markers were only pseudo-elements when 'content'
was different than 'normal'. Otherwise they were anonymous boxes.
This makes them be pseudo-elements in that case too.

This only affects LayoutNG, in legacy they continue being anonymous.

BUG=457718

TEST=accessibility/aria-owns-sends-notification.html
TEST=editing/selection/drag-to-contenteditable-iframe.html
TEST=editing/selection/selectNode.html
TEST=editing/selection/selectNodeContents.html
TEST=external/wpt/css/css-pseudo/marker-computed-size.html
TEST=external/wpt/css/css-pseudo/marker-content-014.html
TEST=blink_unittests --gtest_filter=NGInlineCursorTest/NGInlineCursorTest.NextWithListItem/*
TEST=blink_unittests --gtest_filter=ParameterizedTextPaintTimingDetectorTest.CapturingListMarkers/*
TEST=content_browsertests --gtest_filter=All/DumpAccessibilityTreeTest.AccessibilityLi/*

marker-content-014.html still fails in legacy since markers are not
pseudo-elements yet.

marker-computed-size.html also fails in legacy, and one of the subcases
fails in LayoutNG since 'content: none' doesn't work yet in ::marker.

fast/multicol/span/list-multi-column-crash.html now crashes with
LayoutNGBlockFragmentation enabled due to bug 1040947. The crash was
already happening with ::before and ::after, so it's expected.

Change-Id: I51d9661f32b2e1c0c392c261853f8127b74136fe
Reviewed-on: https://chromium-review.googlesource.com/1985952
WPT-Export-Revision: 1f083243910184ef1020273769b2e80db1273afa

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 18 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

OK : 1
PASS: 6[Gecko-linux64-asan-opt, Gecko-linux64-debug, Gecko-linux64-opt, Gecko-linux64-qr-debug, Gecko-linux64-qr-opt, GitHub] 41[Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 47[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 2

Chrome

OK : 1
PASS: 5
FAIL: 3

Safari

OK : 1
PASS: 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-pseudo/marker-computed-size.html
::marker with no box due to 'list-style': FAIL
::marker with no box due to 'content': FAIL

New Tests That Don't Pass

/css/css-pseudo/marker-computed-size.html
::marker with no box due to 'list-style': FAIL (Chrome: PASS, Safari: PASS)
::marker with no box due to 'content': FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ad63917fab33
[wpt PR 21152] - [css-pseudo] Implement LayoutNG normal markers as real pseudo-elements, a=testonly
https://hg.mozilla.org/integration/autoland/rev/32ae3da5cc3b
[wpt PR 21152] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.