Closed Bug 1609231 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21173 - ElementTiming and LargestContentfulPaint: add more redirect tests

Categories

(Core :: Performance, task, P4)

Product:
Core
Component:
Performance
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21173 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21173
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

ElementTiming and LargestContentfulPaint: add more redirect tests

This CL adds more tests for Timing-Allow-Origin checks in ElementTiming
and LargestContentfulPaint with multiple redirects. Before, we had tests
for:

  • Single cross-origin response with a TAO header (image-TAO.sub.html).
  • Multiple redirects, with '*' TAO header (multi-redirect-image.html).

This CL renames the latter to be more descriptive and adds:

  • Same-origin redirect tests (should pass without TAO headers).
  • Multi-cross-origin redirect tests with various TAO header values.

Bug: 1003943
Change-Id: Id44f0f18f143c8ca4ee3ca40c2383fa2ae22590c
Reviewed-on: https://chromium-review.googlesource.com/2001070
WPT-Export-Revision: d29d76197adf350b58c99e8ddf1c136543b189a4

PR 21173 applied with additional changes from upstream: 3d894444a84e3999a2094e84a877eb8cba94e14e
Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 18 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 83 tests

Status Summary

Firefox

OK : 42
PASS : 41
FAIL : 38
PRECONDITION_FAILED: 4

Chrome

OK : 42
PASS : 39
FAIL : 3

Safari

OK : 42
FAIL : 38
PRECONDITION_FAILED: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/element-timing/observe-svg-image.html
Able to observe svg image.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-background-image.html
Element with elementtiming attribute and background image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-elementtiming.html
Element with elementtiming attribute is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-src-change.html
Element Timing: changing src causes a new entry to be dispatched.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-carousel.html
Entries for elements within an image carousel are dispatched when the elements are redrawn.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/images-repeated-resource.html
Elements with elementtiming and same src are observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/scroll-to-text.html
Paragraph with elementtiming attribute is observed even when not initially visible.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/background-image-multiple-elements.html
Background image affecting various elements is observed.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-video-poster.html
Able to observe a video's poster image.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/disconnect-image.html
Disconnected elements have null as their |element| attribute.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/multiple-background-images.html
Element with two background images receives both.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/retrievability.html
Element Timing entries are not accessible via performance.getEntries*: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/cross-origin-iframe-element.sub.html
Element from cross origin iframe is NOT observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-data-uri.html
Inline image is observable via Element Timing.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-with-css-scale.html
Image intersectionRect is affected by scaling, but not its intrinsic size.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-multiple-images.html
PerformanceObserver can observe multiple image elements.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/rectangular-image.html
Element with rectangular image has correct rect and instrinsic size.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/css-generated-text.html
Generated text content is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/toJSON.html
Test toJSON() in PerformanceElementTiming.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/progressively-loaded-image.html
Element Timing: image render timestamp occurs after it is fully loaded.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-shadow-image.html
Image in shadow tree with elementtiming attribute is not observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-TAO.sub.html
Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/background-image-stretched.html
Element with background image shows correct image size.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/multiple-redirects-TAO.sub.html
Cross-origin images with passing/failing TAO should/shouldn't have its renderTime set.: PRECONDITION_FAILED (Chrome: FAIL, Safari: PRECONDITION_FAILED)
/element-timing/first-letter-background.html
Element with elementtiming attribute and background image in first-letter is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-not-fully-visible.html
The intersectionRect of an img element overflowing is computed correctly: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/fixed-id-identifier.html
PerformanceElementTiming id and identifier do not change when Element changes.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-with-rotation.html
Image intersectionRect is affected by rotation, but not its intrinsic size.: FAIL (Chrome: PASS, Safari: FAIL)
/largest-contentful-paint/same-origin-redirects.html
Same-origin image redirect without TAO should have its renderTime set.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-shadow-text.html
Text in shadow tree with elementtiming attribute is not observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/text-with-display-style.html
Text with display style is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-empty-attribute.html
Able to observe image and text with empty elementtiming attribute.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-text.html
Paragraph with elementtiming attribute is observed.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/same-origin-redirects.html
Same-origin image redirect without TAO should have its renderTime set.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/buffered-flag.html
Element Timing entries are observable via buffered flag.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: FAIL (Chrome: FAIL, Safari: FAIL)
/largest-contentful-paint/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: PRECONDITION_FAILED (Chrome: FAIL, Safari: PRECONDITION_FAILED)
/element-timing/buffer-before-onload.html
Element Timing: image loads before onload available from buffered flag.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/image-clipped-svg.html
Able to observe svg image.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/background-image-data-uri.html
Element with elementtiming attribute and inline background image is observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/cross-origin-element.sub.html
Cross-origin image element is NOT observable.: FAIL (Chrome: PASS, Safari: FAIL)
/element-timing/observe-child-element.html
Element in child iframe is not observed, even if same-origin.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3527d631fbe1
[wpt PR 21173] - ElementTiming and LargestContentfulPaint: add more redirect tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dfcfe5d01938
[wpt PR 21173] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3527d631fbe1
https://hg.mozilla.org/mozilla-central/rev/dfcfe5d01938

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.