Closed Bug 1609239 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21174 - Add alignment.css ref to align-content-distribution tests

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21174 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21174
Details from upstream follow.

Rossana Monteriso <rmonteriso@igalia.com> wrote:

Add alignment.css ref to align-content-distribution tests

This CL:

  • adds a required reference to the alignment.css resource file,
    that provides alignment-related CSS classes used in several test cases.
    Adding this reference fixes the align-content-distribution tests.

  • changes the dimension of grids having 3 rows, .verticalLR and
    .stretchedGrid classes, and gives them a new value of 300px width and
    400px height (by using the class .width300height400).
    This way each row width is now equal to 300px/3=100px, instead of
    the previous dimension of 400px/3=133,33...px. The 133,33...px dimension
    was, in fact, interpreted differently in different browsers,
    thus making some tests fail in WebKit and Firefox.

  • removes the -expected.txt files, related to align-content-distribution
    tests, that were generated when these tests were failing.

Change-Id: I404dd188e8a2275042b4ace218c78a99e3248be5

Reviewed-on: https://chromium-review.googlesource.com/1996303
WPT-Export-Revision: 0a38ed74e042be6e1852bd2fed69b182247011a6

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
PR 21174 applied with additional changes from upstream: 2a73e37c60b18846d9d2798c845242f209d74644

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 24 subtests

Status Summary

Firefox

OK : 3
PASS: 72

Chrome

OK : 3
PASS: 72

Safari

OK : 3
PASS: 72

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05967b3a9dd5
[wpt PR 21174] - Add alignment.css ref to align-content-distribution tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/05967b3a9dd5

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.