Closed Bug 1609437 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21195 - webrtc: Don't show empty rid values and remove obsolete parameters

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21195 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21195
Details from upstream follow.

Florent Castelli <orphis@chromium.org> wrote:

webrtc: Don't show empty rid values and remove obsolete parameters

Bug: 803494
Change-Id: I8e2997bae643f2b5f2f4ae82a3aff8496dd25483
Reviewed-on: https://chromium-review.googlesource.com/2002573
WPT-Export-Revision: d2e373ddaa5e846d383be44a8e39d367f8a310eb

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 20 subtests

Status Summary

Firefox

OK : 1
FAIL: 20

Chrome

OK : 1
PASS: 17
FAIL: 3

Safari

OK : 1
FAIL: 20

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webrtc/RTCRtpParameters-encodings.html
setParameters() with encoding.scaleResolutionDownBy field set to less than 1.0 should reject with RangeError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.scaleResolutionDownBy should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.maxFramerate should succeed without RTCRtpTransceiverInit: FAIL (Chrome: FAIL, Safari: FAIL)
setParameters() with modified encoding.active should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.scaleResolutionDownBy should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.maxBitrate should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.maxFramerate should succeed with RTCRtpTransceiverInit: FAIL (Chrome: FAIL, Safari: FAIL)
addTransceiver() with undefined sendEncodings should have default encoding parameter with active set to true: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.maxBitrate should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.priority should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
sender.setParameters() with mismatch number of encodings should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)
addTransceiver() with empty list sendEncodings should have default encoding parameter with active set to true: FAIL (Chrome: PASS, Safari: FAIL)
sender.getParameters() should return sendEncodings set by addTransceiver(): FAIL (Chrome: FAIL, Safari: FAIL)
sender.setParameters() with encodings unset should reject with TypeError: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.priority should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.active should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with encoding.scaleResolutionDownBy field set to greater than 1.0 should succeed: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.networkPriority should succeed without RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.networkPriority should succeed with RTCRtpTransceiverInit: FAIL (Chrome: PASS, Safari: FAIL)
setParameters() with modified encoding.rid field should reject with InvalidModificationError: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa5285f13b31
[wpt PR 21195] - webrtc: Don't show empty rid values and remove obsolete parameters, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fa5285f13b31

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.