Closed Bug 1609458 Opened 6 years ago Closed 5 years ago

[wpt-sync] Sync PR 21198 - Don't override background-images for all inlines in forced colors

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21198 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21198
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

Don't override background-images for all inlines in forced colors

In a previous change, we had ignored background images for all inlines
to prevent background images from being painted on top of the
readability backplate in forced colors mode.
https://chromium-review.googlesource.com/c/chromium/src/+/1757685

However, it turns out that inline-block, inline-table, inline-flex,
and inline-grid paint their backgrounds before the backplate is
painted. As such, we do not want to ignore background images for these
inlines in forced colors mode.

Bug: 970285
Change-Id: Iee2463775e67a1661cbb85f0a51b5bb8f01566cb
Reviewed-on: https://chromium-review.googlesource.com/1998976
WPT-Export-Revision: a5dca87a3dc9429ae3e9b10bd132f81d6e67c811

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b411931046e [wpt PR 21198] - Don't override background-images for atomic inlines in forced colors, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.