Closed
Bug 1609462
Opened 5 years ago
Closed 5 years ago
Small tweak to modal overlay
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 74
Tracking | Status | |
---|---|---|
firefox74 | --- | verified |
People
(Reporter: thecount, Assigned: thecount)
References
Details
Attachments
(1 file)
Noticed working on another bug the modal overlay positioning might be able to be simplify a bit, by using flex and margin: auto to center it.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → sdowne
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/7fab57c31456
working on modal overlay positioning r=emcminn
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
Comment 4•5 years ago
|
||
I have verified the welcome modal overlay and I can confirm the following:
display
is set toflex
;positon
is set torelative
;margin
is set toauto
;overflow
is set toauto
;z-index
is set to1100
Verified using latest Firefox Nightly (74.0a1 Build ID - 20200119213718) installed on Windows 10 x64, Mac 10.15.2, and Ubuntu 18.04 x64.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•