Closed Bug 1609467 Opened 5 years ago Closed 5 years ago

puppet is still running atboot on scriptworkers

Categories

(Infrastructure & Operations :: RelOps: Posix OS, task)

task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dhouse, Assigned: dhouse)

Details

Attachments

(1 file)

61 bytes, text/x-github-pull-request
mozilla
: review+
sfraser
: review+
Details | Review

Aki found that clientId and AccessToken were missing on tb-mac-v3-signing2 (https://github.com/mozilla-platform-ops/ronin_puppet/issues/174). The machine has /Library/LaunchDaemons/com.mozilla.atboot_puppet.plist -- I need to remove this across all of the ronin-controlled macos scriptworkers.

The bootstrap script is still in as a launch daemon also and not disabled :( I'm removing it and I'll add an ensure-removal to puppet.

[dhouse@tb-mac-v3-signing2.srv.releng.mdc2.mozilla.com ~]$ sudo ls -la /var/root/bootstrap_mojave.log
-rw-r--r--  1 root  wheel  4036402 Jan 15 17:50 /var/root/bootstrap_mojave.log
[dhouse@tb-mac-v3-signing2.srv.releng.mdc2.mozilla.com ~]$ sudo cat /Library/LaunchDaemons/org.mozilla.bootstrap_mojave.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">

    <!-- This Source Code Form is subject to the terms of the Mozilla Public
       - License, v. 2.0. If a copy of the MPL was not distributed with this
       - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

<dict>
        <key>enabled</key>
            <true/>
        <key>Label</key>
            <string>org.mozilla.bootstrap_mojave</string>
        <key>Program</key>
            <string>/var/root/bootstrap_mojave.sh</string>
        <key>ProgramArguments</key>
            <array>
                <string>/var/root/bootstrap_mojave.sh</string>
                <string>-l</string>
                <string>/var/root/bootstrap_mojave.log</string>
            </array>
        <key>RunAtLoad</key>
            <true/>
        <key>LaunchOnlyOnce</key>
            <true/>
        <key>KeepAlive</key>
            <false/>
</dict>
</plist>

This looks like I need to audit and change puppet to control all of the LaunchDaemons/Agents.

killed the bootstrap (and removed the launchdaemon):

[dhouse@tb-mac-v3-signing2.srv.releng.mdc2.mozilla.com code]$ ps -ef|grep bootstrap
    0    90     1   0 11:21PM ??         0:00.63 /bin/bash /var/root/bootstrap_mojave.sh -l /var/root/bootstrap_mojave.log
   29 44632 42992   0  6:06PM ttys000    0:00.00 grep bootstrap
[dhouse@tb-mac-v3-signing2.srv.releng.mdc2.mozilla.com code]$ sudo kill -9 90
Attached file GitHub Pull Request
Attachment #9121104 - Flags: review?(sfraser)
Attachment #9121104 - Flags: review?(aki)
Attachment #9121104 - Flags: review?(sfraser) → review+
Attachment #9121104 - Flags: review?(aki) → review+

mac-v3-signing9.srv.releng.mdc1.mozilla.com was affected:
atboot and bootstrap were both in /Library/LaunchDaemons. I unloaded+removed both plists and killed the processes

It'll be any node that was imaged before the puppet changes, right? It's masterless puppet, so no updates after imaging.

(In reply to Simon Fraser [:sfraser] ⌚️GMT from comment #6)

It'll be any node that was imaged before the puppet changes, right? It's masterless puppet, so no updates after imaging.

+/right, when puppet is run next/again, it will verify the atboot plist is not in place.

I manually removed the atboot/bootstrap from mac-v3-signing{1,2,3,7,8,9}.srv.releng.mdc1 and mac-v3-signing{4,5,6,10,11,12,13}.srv.releng.mdc2
So, they are not running and will not run unless we add them in the future.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

the ronin-puppet PR is merged

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: