Closed Bug 1609498 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 21203 - [css-grid] Fix grid-layout-properties.html WPT test

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21203 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21203
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-grid] Fix grid-layout-properties.html WPT test

This is a follow-up of r728894. It affected the behavior of the WPT test
grid-layout-properties.html, but I didn't notice it since it was marked
as failing.

Mozilla updated the test in https://bugzil.la/1599206, but they didn't
cover some cases that were already failing for them since Firefox
doesn't serialize shorthands.

Also, a case that used to expect "150px 50px 50px" should have been
changed to "150px" (removing the trailing implicit tracks), but Mozilla
changed it to "50px" since it's what they get due to a Firefox bug.

Here I'm fixing the test to expect the correct values, unmarking it as
failing, and adding an -expected.txt for the cases that fail due to
bug 511177.

BUG=1024927

Change-Id: I7ff8d248a708af273cd89d438ffd2692783a5bc4
Reviewed-on: https://chromium-review.googlesource.com/2002579
WPT-Export-Revision: dc499c3011a52001e4551b77435b7419f628db6a

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 140 subtests

Status Summary

Firefox

OK : 1
PASS: 98
FAIL: 42

Chrome

OK : 1
PASS: 119
FAIL: 21

Safari

OK : 1
PASS: 105
FAIL: 35

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-grid/grid-layout-properties.html
grid-column.<integer>: FAIL
grid-column.span <custom-ident>: FAIL
grid-area.<integer>: FAIL
grid-row.span <integer> <custom-ident>: FAIL
grid-row.<custom-ident>: FAIL
grid-column-end.span <custom-ident>: FAIL
grid-column.span <integer>: FAIL
grid-row-start.span <custom-ident>: FAIL
grid-area.<custom-ident>: FAIL
grid-row.<integer>: FAIL
grid-row.span <integer>: FAIL
grid-row.span <custom-ident>: FAIL
grid-row-end.span <custom-ident>: FAIL
grid-column.<integer> <ident>: FAIL
grid-area.span <integer>: FAIL
grid-area.span <custom-ident>: FAIL
grid-column.<custom-ident>: FAIL
grid-column.span <integer> <custom-ident>: FAIL
grid-row.<integer> <ident>: FAIL
grid-area.span <integer> <custom-ident>: FAIL
grid-column-start.span <custom-ident>: FAIL
grid-area.<integer> <ident>: FAIL

New Tests That Don't Pass

/css/css-grid/grid-layout-properties.html
grid-row.<integer> start: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row.auto: FAIL (Chrome: FAIL, Safari: FAIL)
grid-column.<integer>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.initial: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row.reset: FAIL (Chrome: FAIL, Safari: FAIL)
grid-column.span <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-template.none: FAIL (Chrome: FAIL, Safari: FAIL)
grid-area.<integer>: FAIL (Chrome: PASS, Safari: PASS)
grid-row.span <integer> <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-area.reset: FAIL (Chrome: FAIL, Safari: FAIL)
grid-template.<string>+: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row.<custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column-end.span <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.span <integer>: FAIL (Chrome: PASS, Safari: PASS)
grid-template.initial: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row-start.span <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.auto: FAIL (Chrome: FAIL, Safari: FAIL)
grid-area.<custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-row.<integer>: FAIL (Chrome: PASS, Safari: PASS)
grid-row.initial: FAIL (Chrome: FAIL, Safari: FAIL)
grid-template.reset: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row.span <integer>: FAIL (Chrome: PASS, Safari: PASS)
grid-template.<grid-template-rows> / <grid-template-columns>: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row.span <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-area.auto: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row-end.span <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.<integer> <ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-area.span <integer>: FAIL (Chrome: PASS, Safari: PASS)
grid-area.span <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.<custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.span <integer> <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.reset: FAIL (Chrome: FAIL, Safari: FAIL)
grid-template.<string><track-size>+: FAIL (Chrome: FAIL, Safari: FAIL)
grid-row.<integer> <ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-area.span <integer> <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column-start.span <custom-ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-column.<integer> start: FAIL (Chrome: FAIL, Safari: FAIL)
grid-area.initial: FAIL (Chrome: FAIL, Safari: FAIL)
grid-area.<integer> start: FAIL (Chrome: FAIL, Safari: FAIL)
grid-template-rows.<track-size>.<track-breadth>.<percentage>: FAIL (Chrome: PASS, Safari: FAIL)
grid-area.<integer> <ident>: FAIL (Chrome: PASS, Safari: PASS)
grid-template.<line-names>: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/953ab4b05422 [wpt PR 21203] - [css-grid] Fix grid-layout-properties.html WPT test, a=testonly https://hg.mozilla.org/integration/autoland/rev/6d4e508ac492 [wpt PR 21203] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/953ab4b05422
https://hg.mozilla.org/mozilla-central/rev/6d4e508ac492

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.