Closed Bug 1609637 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21217 - [WPT/common/security-features] Support sub projects and split referrer-policy 4K tests

Categories

(Core :: DOM: Security, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Attachments

(1 file)

Sync web-platform-tests PR 21217 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21217
Details from upstream follow.

Hiroshige Hayashizaki <hiroshige@chromium.org> wrote:

[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests

This CL implements the support for sub projects in common/security-features infra,
to support similar but slightly different generated tests.
See README.md changes for how it works.
Particularly, this CL implements logics to read and merge multiple spec.src.jsons,
and include multiple test-case.sub.js in generated tests.

By using sub projects, this CL split referrer-policy tests for
4KB referrer policy length limitations into separate generated files under
e.g. referrer-policy/4K/gen/.
Previously, the 4KB limit tests are done within the same files as
the main referrer-policy tests. They required multiple forward and back
navigations via history.replaceState and history.back
within a single generated test,
and this hit race conditions and interoperability issues,
especially around history.back navigations + \<iframe> navigations.
After this CL, only one forward navigation occurs per one test file.

This CL doesn't affect existing generated files, because they
don't use sub projects.
The newly generated files under referrer-policy/4K* will be added by
https://chromium-review.googlesource.com/c/chromium/src/+/1993003/.

Bug: 906850
Change-Id: Ic2d3de0492b097adf293f55ebcbe4690065e4ba8

Reviewed-on: https://chromium-review.googlesource.com/1991066
WPT-Export-Revision: 191862fabf255a3b1af7cfb11bd3a7e0f52bbe49

PR 21217 applied with additional changes from upstream: d0adb1443bac2da650b04db557cf38ae6b368071, 61616b5bfd5e7c0e86e68b6e4fbb0192ba78d170
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Whiteboard: [wptsync downstream][domsecurity-backlog] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Attached file Notable wpt changes
# CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2394 tests and 1 subtests

## Status Summary

### Firefox
OK  : 500[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 2353[GitHub]
PASS: 41[Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 541[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 1991[GitHub]
FAIL: 362

### Chrome
OK  : 2353
PASS: 2353

### Safari
OK  : 2353
PASS: 1304
FAIL: 1049

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef6c3f33a459db47ffda8896ee1e3647a90ad68d)
[GitHub PR Head](https://wpt.fyi/results/?sha=142689264a1ca0a18ebd1d66315775063354f26f&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=142689264a1ca0a18ebd1d66315775063354f26f&label=pr_base)

## Details

(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/12bc84953013
[wpt PR 21217] - [WPT/common/security-features] Support sub projects and split referrer-policy 4K tests, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: