1609670 - [wpt-sync] Sync PR 21220 - [css-pseudo] Support 'content: none' for ::marker

Status: RESOLVED FIXED

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21220 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21220
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-pseudo] Support 'content: none' for ::marker

Unlike ::before and ::after, in ::marker 'content: normal' and 'none'
should behave differently: the former should display it normally, the
latter should prevent it from generating a box.

Before this patch, 'normal' and 'none' were both stored as nullptr, so
they were indistinguishable. This patch makes 'none' be stored as a
NoneContentData instead.

However, 'none' keeps behaving as 'normal' for anything different than
::marker. In getComputedStyle, 'none' keeps resolving to 'normal' for
anything different than ::marker, ::before and ::after, and 'normal'
keeps resolving to 'none' for ::before and ::after.

Inheritance is not affected either since the 'content' property can't
be inherited.

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-computed-content.html
TEST=external/wpt/css/css-pseudo/marker-computed-size.html
TEST=external/wpt/css/css-pseudo/marker-content-019.html

Change-Id: Ib71ef18dfb7f7c98e76888bffb408a17fa458235
Reviewed-on: https://chromium-review.googlesource.com/2002517
WPT-Export-Revision: 99f08d0e85a40e3d17587389145a4404eb621264

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6316dfb807e3a185b05c3fc48258651f34e3d002

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 43 tests

Status Summary

Firefox

OK : 1
PASS: 8[GitHub] 49[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 3

Chrome

OK : 1
PASS: 8
FAIL: 3

Safari

OK : 1
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-computed-content.html
Computed 'content' for non-list-item ::marker, variant none: FAIL (Chrome: FAIL, Safari: FAIL)
Computed 'content' for list-item ::marker, variant none: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-pseudo/marker-content-019.html: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f302f173b380
[wpt PR 21220] - [css-pseudo] Support 'content: none' for LayoutNG ::marker, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5bc67cca1829
[wpt PR 21220] - Update wpt metadata, a=testonly

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f302f173b380
https://hg.mozilla.org/mozilla-central/rev/5bc67cca1829