1609677 - Inspecting a bound function should select the dbgObj.boundTargetFunction in the debugger panel

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This issue is being originated from the following React DevTools extension issue:

• https://github.com/facebook/react/issues/17681

but it is not specific to the devtools extensions, the inspect binding provided by the webconsole is affected by the same issue.

See https://github.com/facebook/react/issues/17681#issuecomment-574617158 for the STR used to reproduce it using the React DevTools extension.

What happened?

toolbox.inspectObjectActor throws TypeError: objectGrip.location is undefined because the object is a bound function and the remote debugger server can't provide a location for it.

What should have happened?

The target bound function should have been selected in the debugger panel.

Anything else we should know?

When a debug object is a bound function dbgObj.isBoundFunction is true and the dbgObj.boundTargetFunction property is set to the target bound function.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1609677 - Inspect the boundTargetFunction if the target object is a bound function.

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try (without new test cases yet):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8db8b4ca689480d00646285360d2280c0a975e4d

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try (updated patch + additional test cases):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7c0aa9144f396664877d18887ea8efe2218ea2f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f44339f9984d
Inspect the boundTargetFunction if the target object is a bound function. r=nchevobbe

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f44339f9984d