1609793 - FinderParent.jsm shouldn't check the fission.autostart pref to decide if there are any out of process iframes

Status: RESOLVED FIXED

(Core :: Find Backend, defect)

Description

[Andrew McCreight [:mccr8]]

This code contains the comment:

// If the modal highlighter is on, and there are no out-of-process child
// frames, send a message only to the top-level frame and set the useSubFrames
// flag, so that the finder iterator iterates over subframes. If there is
// an out-of-process subframe, modal highlighting is disabled.

It checks if there's an out-of-process child frame by seeing if the fission.autostart pref is set. However, it is possible to have an out-of-process child frames even if the pref is set to false, and it is also possible to have an in process child frame if the pref is not set.

You can check the useRemoteSubframes property on a docshell it see if it is out of process or not. We're also considering adding it to the browsing context to make it easier to check.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly (M6)

Comment 2

[Andrew McCreight [:mccr8]]

There's also a check for the Fission pref in nsXPLookAndFeel::GetColorImpl() that also landed in bug 1553384. It looks like this could end up with getting the wrong value, but this code looks pretty removed from anywhere we could access a docshell, so I'm not sure if there's a good fix.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.