Closed Bug 1609955 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21233 - Portals: Make HTMLPortalElement keyboard focusable

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21233 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21233
Details from upstream follow.

Adithya Srinivasan <adithyas@chromium.org> wrote:

Portals: Make HTMLPortalElement keyboard focusable

Also simulates a click when clicking enter/space when a portal is
focused (similar to buttons).

Bug: 1043127
Change-Id: I0b1a35cd978c191a958dea0ed47bf737cac7292f

Reviewed-on: https://chromium-review.googlesource.com/1995940
WPT-Export-Revision: 0620aacca0f688d466ae3543356d9221108cf904

PR 21233 applied with additional changes from upstream: 18b5f8b51f793aa9dedced4addbaacd33048bc32

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

PASS : 41
TIMEOUT: 2
NOTRUN : 6

Chrome

TIMEOUT: 2
NOTRUN : 6

Safari

TIMEOUT: 2
NOTRUN : 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/portals/portals-focus.sub.html: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
test that an element inside a portal's x-origin subframe cannot steal focus: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
test that an element inside a portal cannot steal focus: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
test that a x-origin iframe inside an adopted portal cannot steal focus: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
test that an element inside an adopted portal cannot steal focus: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
test that a portal is keyboard focusable: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
test that we cannot tab into a portal's contents: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
test that a portal is keyboard activatable: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3d5b16138f7
[wpt PR 21233] - Portals: Make HTMLPortalElement keyboard focusable, a=testonly
https://hg.mozilla.org/integration/autoland/rev/701bc5d25b2f
[wpt PR 21233] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d3d5b16138f7
https://hg.mozilla.org/mozilla-central/rev/701bc5d25b2f

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.