1609990 - Store agent cluster ID in structured clone buffer

Status: RESOLVED FIXED

(Core :: DOM: postMessage, task)

Description

[Andrea Marchesini [:baku]]

We need to store the agent cluster ID in the structured clone buffer in order to decide when and how data should be deserialized. SharedArrayBuffers and WASM modules cannot pass the agent cluster boundary.

This is a follow-up of bug 1605566.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 2 - MessageDataType, r?smaug

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 2 - sameAgentCluster callback, r?sfink,smaug

Depends on D60428

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 3 - StructuredCloneHolder::AgentCluster, r?smaug

Depends on D60429

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 4 - tests, r?smaug

Depends on D60430

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 1 - No JS exceptions, r?smaug

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 3 - CloneDataPolicy, r?smaug,sfink

Depends on D60428

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bae3e50ab64d
AgentCluster comparison in MessagePort and BroadcastChannel - part 1 - No JS exceptions, r=smaug
https://hg.mozilla.org/integration/autoland/rev/c95aac908332
AgentCluster comparison in MessagePort and BroadcastChannel - part 2 - MessageDataType, r=smaug
https://hg.mozilla.org/integration/autoland/rev/d4524885cb97
AgentCluster comparison in MessagePort and BroadcastChannel - part 3 - CloneDataPolicy, r=smaug,sfink,lth
https://hg.mozilla.org/integration/autoland/rev/81a77bb3772c
AgentCluster comparison in MessagePort and BroadcastChannel - part 4 - tests, r=smaug

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1609990) for causing Spidermonkey rust bustage CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=286367048&resultStatus=testfailed%2Cbusted%2Cexception&revision=81a77bb3772c5b1bf504f016521a6c5644abefbc

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=286367048&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/4d6eefde275e6fa74cbc45883f922dcd0405f925

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e50d45872c7
AgentCluster comparison in MessagePort and BroadcastChannel - part 1 - No JS exceptions, r=smaug
https://hg.mozilla.org/integration/autoland/rev/b68593cbccda
AgentCluster comparison in MessagePort and BroadcastChannel - part 2 - MessageDataType, r=smaug
https://hg.mozilla.org/integration/autoland/rev/298964256328
AgentCluster comparison in MessagePort and BroadcastChannel - part 3 - CloneDataPolicy, r=smaug,sfink,lth
https://hg.mozilla.org/integration/autoland/rev/519a3bf8de94
AgentCluster comparison in MessagePort and BroadcastChannel - part 4 - tests, r=smaug

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3e50d45872c7
https://hg.mozilla.org/mozilla-central/rev/b68593cbccda
https://hg.mozilla.org/mozilla-central/rev/298964256328
https://hg.mozilla.org/mozilla-central/rev/519a3bf8de94