Closed Bug 1609992 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21239 - Limit inline negative margin quirks only when line overflows

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21239 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21239
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

Limit inline negative margin quirks only when line overflows

crbug.com/979894 and crbug.com/1011816 revealed that, boxes
with inline negative margins can be put back to the line even
if they appear beyond the end margin. The behavior is not
defined in the spec, but supported because all browsers do it
and there are good amount of sites relying on the behavior.

The special behavior, however, turned out that it should
apply only when the line overflows.

Similar to the fixes in the issues above, this behavior is
not well-defined, not really interoperable, and sometimes
the result of combinations of bugs. This patch takes the
behavior that are interoperable and somewhat reasonable,
while fixes the reported page.

Bug: 1040461
Change-Id: I3e4883220645a59dd3c33bdad4116f200fc4208d

Reviewed-on: https://chromium-review.googlesource.com/2000412
WPT-Export-Revision: 06d85ba693a9ef5ca9e2afb9bf47553f0a4ba3f3

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

OK : 1
PASS: 12[GitHub] 53[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 1

Chrome

OK : 1
PASS: 10
FAIL: 3

Safari

OK : 1
PASS: 10
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/CSS2/linebox/inline-negative-margin-001.html
[data-expected-height] 11: FAIL

New Tests That Don't Pass

/css/CSS2/linebox/inline-negative-margin-001.html
[data-expected-height] 11: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9978cee8889
[wpt PR 21239] - Limit inline negative margin quirks only when line overflows, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e9978cee8889

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.