Closed Bug 1610011 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21243 - CL followup - run ESLint, throw from math helper

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21243 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21243
Details from upstream follow.

Piotr Bialecki <bialpio@chromium.org> wrote:

CL followup - run ESLint, throw from math helper

Changes:

  • ran ESLint on webxr-test.js and xr-internal-device-mocking.js
  • xr-internal-device-mocking.js now stores the
    MockRuntime._injectAdditionalFrameData() before overwriting it with
    its own implementation, and calls the original implementation as the
    first step
  • throw instead of console.warn when math helper encounters unexpected
    combinations of .w component
    Change-Id: I94c015b5c89cfbc0e1a4b90db6ec44a198f4ce05
    Reviewed-on: https://chromium-review.googlesource.com/2008073
    WPT-Export-Revision: e3998988a4ef392797225dda54aa0d8fa3678422
PR 21243 applied with additional changes from upstream: 62c94c1e9ed588bebd1ac6874108a4bd5bf80510, 07ee5f0e12ff938041b5c3a7bac5a44aebe0f2e7, 2916d13a6d8a4fb26669bfa1bc70babad7ecfaf4
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f19b4393a1a
[wpt PR 21243] - CL followup - run ESLint, throw from math helper, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/4f19b4393a1a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.