Remove localization support from firefox-puppeteer
Categories
(Remote Protocol :: Marionette, task, P1)
Tracking
(firefox74 fixed)
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: zbraniecki, Assigned: whimboo)
References
Details
(Keywords: pi-marionette-firefox-puppeteer)
Attachments
(1 file)
Based on bug 1608022 comment 5, we should stop relying on DTD for command shortcuts in testing.
List blocking bug 1608022:
- tabCmd.commandkey and closeCmd.key used in testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/tabbar.py
- pageInfoCmd.commandkey and closeCmd.key used in testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/window.py
- addons.commandkey and searchFocus.commandkey used in testing/firefox-ui/tests/functional/keyboard_shortcuts/test_browser_window.py
- newNavigatorCmd.key and privateBrowsingCmd.commandkey used in testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/window.py
- openCmd.commandkey and reloadCmd.commandkey used in testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/toolbars.py
Assignee | ||
Comment 1•4 years ago
|
||
Given that testing localized builds isn't really wanted anymore, the following files have to be removed:
https://searchfox.org/mozilla-central/source/testing/marionette/client/marionette_driver/localization.py
https://searchfox.org/mozilla-central/source/testing/marionette/l10n.js
https://searchfox.org/mozilla-central/source/testing/marionette/puppeteer/firefox/firefox_puppeteer/api/l10n.py
Appropriate callers have to be updated.
Assignee | ||
Comment 2•4 years ago
|
||
Actually the code in Marionette doesn't block bug 1608022, and as such we should just leave it there also for backward compatibility. Removing only the firefox-puppeteer code should be fine.
Assignee | ||
Comment 3•4 years ago
|
||
Given that this is a real blocker for l20n work, I had to take a look. So hopefully that should be it:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa753aeb9ed7983c31295ffeb718fc19c080583d
Assignee | ||
Comment 4•4 years ago
|
||
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32761b514257 [marionette] Remove localization support from firefox-puppeteer. r=marionette-reviewers,maja_zf
Comment 6•4 years ago
|
||
bugherder |
Updated•1 year ago
|
Description
•