implement "log filter use". in 4.x, we had UI in the filter dialog to enable / disable the filter log, and we had a button to view the filter log. andy edmonds suggests: "In addition to gestures for mail, a killer feature for my email usage is a filter report. When 14 messages come in and only 1 appears in the inbox, I'd like to know where the other messages went. I'm imagining a visual overlay while mail is being read that shows titles and destinations as messages come in and offers a post-read tally of messages placed in each folder. The ease of implementation has yet to be determined..." Not sure what UI we'd go with at this time. We could share some UI concepts with viewing the output of any SPAM detection, too.
Please see filter spec at: http://www.mozilla.org/mailnews/specs/filters/
Created attachment 98206 [details] [diff] [review] patch for the UI to view the log (ViewLog() needs to be finished)
Created attachment 98223 [details] [diff] [review] add "Log Filter Use" checkbox, hook it up, and implement "View Log"
Attachment #98206 - Attachment is obsolete: true
Created attachment 98237 [details] [diff] [review] implement FE and BE parts (imap needs testing, need to keep the stream open, too)
Attachment #98223 - Attachment is obsolete: true
hoping for 1.2 beta.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.2beta
note, that screen shot doesn't match the spec. but it's a good start for 1.2. we'll do more later.
Created attachment 98345 [details] [diff] [review] updated patch, append to the log. seems to be working for imap and pop
Attachment #98237 - Attachment is obsolete: true
imap seems to be logging twice (bug in my patch), but other than that all I have left before I seek reviews: 1) keeping the stream open (so we don't write to disk so often) 2) ignore the log file so it doesn't show in the folder pane
todo list: 1) keeping the stream open (so we don't write to disk so often) 2) ignore the log file so it doesn't show in the folder pane 3) imap logs twice per hit
latest patch in bug 142845
Created attachment 98397 [details] [diff] [review] update todo: keep stream open, don't use obsolete interfaces / classes imap logging twice.
Attachment #98345 - Attachment is obsolete: true
Created attachment 98564 [details] screenshot, including filter after the fact UI
Attachment #98238 - Attachment is obsolete: true
Created attachment 98565 [details] [diff] [review] add some filter after the fact UI, fix double logging for imap issue.
Attachment #98397 - Attachment is obsolete: true
Wouldn't it make more sense to have the 'Log Filter Use' checkbox above the 'View Filter Log' button?
Created attachment 98652 [details] [diff] [review] patch
Attachment #98565 - Attachment is obsolete: true
Created attachment 98656 [details] [diff] [review] patch address comments from bienvenu
Attachment #98652 - Attachment is obsolete: true
Comment on attachment 98656 [details] [diff] [review] patch looks good, sr=bienvenu
Attachment #98656 - Flags: superreview+
Comment on attachment 98656 [details] [diff] [review] patch r=mscott
Attachment #98656 - Flags: review+
fixed. also in that last patch is some UI for filter after the fact. we don't match the spec 100%. I'll log some spin off bugs to cover those issues.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
OK using oct14 commercial trunk: win98, mac OS 10.1, linux rh6.2 Verified filter engages and generally works for POP and IMAP accounts. Any specific issues found with the filter log will be reported separately.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.