Open Bug 1610213 Opened 4 years ago Updated 10 months ago

Crash in [@ __CFRunLoopServiceMachPort]

Categories

(Core :: General, defect)

73 Branch
defect

Tracking

()

Tracking Status
firefox-esr78 --- wontfix
firefox83 --- wontfix

People

(Reporter: yoasif, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: crash, topcrash)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-45b65755-176b-40db-a8b2-ecd3b0200119.

Top 10 frames of crashing thread:

0 libsystem_kernel.dylib mach_msg_trap 
1 CoreFoundation __CFRunLoopServiceMachPort 
2 CoreFoundation __CFRunLoopRun 
3 CoreFoundation CFRunLoopRunSpecific 
4 HIToolbox RunCurrentEventLoopInMode 
5 HIToolbox ReceiveNextEventCommon 
6 HIToolbox _BlockUntilNextEventMatchingListInModeWithFilter 
7 AppKit _DPSNextEvent 
8 AppKit -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 
9 AppKit GCC_except_table7 

Forced Firefox to crash due to multiple hung content processes. This has been happening for a week or two now. I was unable to capture a profile because the profiler would not start after installation.

If I see this again (the hung content processes), I will try to capture a profile and post here. Happy to provide any further information.

The priority flag is not set for this bug.
:ajones, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(ajones)
Component: General → Widget: Cocoa

Since this has to do with hung content processes I'm going to move this over to IPC for now.

Component: Widget: Cocoa → IPC
Flags: needinfo?(ajones)

The priority flag is not set for this bug.
:jld, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jld)

No evidence that it's IPC, and nothing actionable in comment #0 because the crash report is for the wrong process. (Also the summary is misleading — it was a deliberate crash of an idle process, so the fact that it hit the place where an event loop waits for events is of little informational value.) Resolving as incomplete to stop the bot nagging; reopen if there's more information.

Status: NEW → RESOLVED
Closed: 4 years ago
Component: IPC → General
Flags: needinfo?(jld)
Resolution: --- → INCOMPLETE
Crash Signature: [@ __CFRunLoopServiceMachPort] → [@ __CFRunLoopServiceMachPort] [@ shutdownhang | __CFRunLoopServiceMachPort]

This is a Cocoa Widgets bug. Or at least some of these crashes are.

Bug 1577886 landed support for mac_crash_info data in Mozilla crash reports. Now one has appeared with this bug's signature and very interesting mac_crash_info data:

    {
      "num_records": 1,
      "records": [
        {
          "message": "Calling windowShouldClose: on the delegate for the ToolbarWindow 0x115acc800",
          "module": "/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit"
        }
      ]
    }

bp-f56a9f79-4556-4024-bb01-13c7a0210525

I haven't investigated, but I suspect this "message" is written just before the call that hangs. It would normally be zeroed out again if that call succeeds. But in this case it didn't.

Edit: This is exactly what happens.

Status: RESOLVED → REOPENED
Component: General → Widget: Cocoa
Resolution: INCOMPLETE → ---
Attachment #9223404 - Attachment description: Entire callstack for crashing thread → Entire callstack for crashing thread (bp-f56a9f79-4556-4024-bb01-13c7a0210525)

Steven, I'm not familiar with mac_crash_info and I'll make sure to read up on it in bug 1577886. In the meantime, could you tell us how the mac_crash_info data in this instance is adding more info? It looks like frame 45 in the call stack indicated that we were requesting a window to close, and we are dealing with a hang since the process is ultimately killed (see MOZ_CRASH reason "Shutdown hanging at step quit-application. Something is blocking the main-thread."). Thank you

Flags: needinfo?(smichaud)

I still haven't investigated this bug in any detail. But I suspect that, in this one case at least, there's something wrong with the "delegate", or maybe with "ToolbarWindow 0x115acc800". For example it might already have been destroyed.

Flags: needinfo?(smichaud)

Here's another (possibly more informative) crash report with the same mac_crash_info:

bp-04da2905-07f3-44b2-843b-757c40210525

I'll tentatively assign this to myself. It'll be a while before I can spend much time on it.

I'll unassign it if I decide I don't have the time, or if I give up on it.

Assignee: nobody → smichaud
Status: REOPENED → ASSIGNED

I'm giving up on this bug, for the time being at least.

I've found another crash report, with different mac_crash_info, that might be relevant:

bp-516f791e-e4b4-47c2-acc2-1aab00210603

    {
      "num_records": 1,
      "records": [
        {
          "message": "Performing @selector(menuItemHit:) from sender NSMenuItem 0x1308c9580",
          "module": "/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit"
        }
      ]
    }

But the evidence is still too sparse.

With luck we'll see more mac_crash_info on crashes with this signature. Once more has accumulated, I may come back to this bug.

Assignee: smichaud → nobody
Status: ASSIGNED → NEW
Component: Widget: Cocoa → General
See Also: → 1705365
See Also: → 1734733

I think this is mostly something very similar if not the same as bug 1705365. If you look at the "Xpcom spin event loop stack" annotations of these crashes you will find many different recursive nestings of prompts/Prompter.jsm:openPromptSync.

See Also: → 1696397

If you look at the "Xpcom spin event loop stack" annotations of these crashes you will find many different recursive nestings of prompts/Prompter.jsm:openPromptSync.

Where in the crash reports do you find these? (I looked at a few and didn't see any.) Are they in a searchable field?

Flags: needinfo?(jstutte)

Lookout for XPCOMSpinEventLoopStack on the Crash Annotations tab of a single crash report like this. You can also search, filter and aggregate this field.

Flags: needinfo?(jstutte)

(If you look at content processes, be aware of bug 1741131)

Note that, in most cases where this annotation is present, there's only one instance of prompts/Prompter.jsm:openPromptSync. I assume this means there are no nested dialogs.

(In reply to Steven Michaud [:smichaud] (Retired) from comment #19)

Note that, in most cases where this annotation is present, there's only one instance of prompts/Prompter.jsm:openPromptSync. I assume this means there are no nested dialogs.

Yes, that's how to read it. These might also be cases (or regressions) not fixed by bug 1696397.

The bug is linked to a topcrash signature, which matches the following criteria:

  • Top 5 desktop browser crashes on Mac on beta
  • Top 5 desktop browser crashes on Mac on release (startup)

:ghess, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Flags: needinfo?(ghess)

Crash counts are not increasing, no need to increase severity at this time.

Flags: needinfo?(ghess)
Severity: normal → S3

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit auto_nag documentation.

The bug is linked to a topcrash signature, which matches the following criterion:

  • Top 5 desktop browser crashes on Mac on release (startup)

:haik, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Flags: needinfo?(haftandilian)

S2 seems like the correct severity for this bug. It is flagged as a startup crash here, but 97% of the crashes (4717 in number) over the last 3 months are not startup crashes.

Flags: needinfo?(haftandilian)

Based on the topcrash criteria, the crash signatures linked to this bug are not in the topcrash signatures anymore.

For more information, please visit BugBot documentation.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: