1610249 - Typo in chown command in base Dockerfile

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Stephane]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Cloned latest Socorro sources from https://github.com/mozilla-services/socorro, and tried to built the Socorro project via guidelines in https://socorro.readthedocs.io/en/latest/overview.html
Checked the base Dockerfile which is used to built all images in path docker, and found an odd statement on line 10:
chown app.app /app/
and 39:
RUN chown -R app.app /mdsw /stackwalk
Expected both to have: app:app iso app.app

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I looked into this because I wrote that code. I've been using . for decades and I was puzzled.

Per the GNU coreutils docs:

Some older scripts may still use ‘.’ in place of the ‘:’ separator. POSIX 1003.1-2001 (see Standards conformance) does not require support for that, but for backward compatibility GNU chown supports ‘.’ so long as no ambiguity results. New scripts should avoid the use of ‘.’ because it is not portable, and because it has undesirable results if the entire owner‘.’group happens to identify a user whose name contains ‘.’.

So, . works as long as the identities aren't ambiguous, but we should update to :.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5169: bug 1610249: switch . to : in chown calls

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5169: "bug 1610249: switch . to : in chown calls" in eb63617.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This went to production just now in bug #1613110.