[wpt-sync] Sync PR 21259 - [LayoutNG] Remove IsIntermediateLayout flag.
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 21259 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/21259
Details from upstream follow.
Ian Kilpatrick <ikilpatrick@chromium.org> wrote:
[LayoutNG] Remove IsIntermediateLayout flag.
Previously if we synthesized the min/max sizes by performing a layout
on the orthogonal subtree - we could end up in a situation where the
"DCHECK(!constraint_space.IsIntermediateLayout() || box_->NeedsLayout())"
was hit.This was caused by a legacy layout fieldset needing a preferred widths
recalc.This is an indirect fix for the below DCHECK bug. Removing the
IsIntermediateLayout flags means that we now perform a copy back when
we are in this (relatively rare) phase.The IsIntermediateLayout was initially introduced as a performance
optimization - however it could also hurt performance if we perform
a correct layout of a subtree with a fixed size.
(we'd need to layout that sub-tree twice, getting exactly the same
layout result).Bug: 1039241
Change-Id: I468a9c8e26b5e7855a72ddb2b1f2614538cedd21Reviewed-on: https://chromium-review.googlesource.com/2007422
WPT-Export-Revision: 8d80a7002f00c7fd65b1aeee7047346c75cb4e61
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca767016dfbca2277e6537257afda93bfbffe3f8
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4740263d1dc2 [wpt PR 21259] - [LayoutNG] Remove IsIntermediateLayout flag., a=testonly
|
|
Assignee | |
Comment 3•4 years ago
|
||
Test result changes from PR not available.
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•