Closed Bug 1610296 Opened 4 years ago Closed 4 years ago

Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState

Categories

(Core :: DOM: Bindings (WebIDL), enhancement, P2)

Product:
Core
Component:
DOM: Bindings (WebIDL)
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: edgar, Assigned: edgar)

Details

Attachments

(1 file)

bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState;
47 bytes, text/x-phabricator-request
Details | Review

This is filed as a follow-up bug of https://phabricator.services.mozilla.com/D59999#inline-366334.

Consumers also need to call ComputeLengthAndData() before they call IsShared(). ComputeLengthAndData() not only computes length and data, but also sharedness, so renaming ComputeLengthAndData() to ComputeState() probably makes the API clearer.

Assignee: nobody → echen

Edgar, did you mean to request review?

Priority: -- → P2

Yes, it is ready to review.

Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7618404411ed
Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky

https://hg.mozilla.org/mozilla-central/rev/7618404411ed

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.