1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement, P2)

Description

[Edgar Chen [:edgar]]

This is filed as a follow-up bug of https://phabricator.services.mozilla.com/D59999#inline-366334.

Consumers also need to call ComputeLengthAndData() before they call IsShared(). ComputeLengthAndData() not only computes length and data, but also sharedness, so renaming ComputeLengthAndData() to ComputeState() probably makes the API clearer.

Comment 1

[Edgar Chen [:edgar]]

Attachment: bug 1610296 - Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState;

Comment 2

[Boris Zbarsky [:bzbarsky]]

Edgar, did you mean to request review?

Comment 3

[Edgar Chen [:edgar]]

Yes, it is ready to review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7618404411ed
Rename TypedArray_base::ComputeLengthAndData to TypedArray_base::ComputeState; r=bzbarsky

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7618404411ed