Closed Bug 1610353 Opened 1 month ago Closed 1 month ago

Extend the Login Storage API to support reporting used logins

Categories

(GeckoView :: General, task, P1)

Unspecified
All

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [geckoview:m74])

Attachments

(5 files)

Extend LoginStorage.Delegate to report when GV uses an existing password, as returned by onLoginFetch, to autofill fields.
Initially, GV will only report when the password field of a LoginEntry is used, which might be extended to support username field usage in future.

This can be used to update meta information of the login entry, like "times used" or "last used".

Depends on D60441

Depends on D60442

Depends on D60443

Priority: -- → P1
Whiteboard: [geckoview:m74]
Attachment #9122337 - Attachment description: Bug 1610353 - [5.0] Update API changelog. → Bug 1610353 - [5.1] Update API changelog.
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d45cb4828442
[1.0] Add LoginStorage onLoginUsed API. r=snorp,geckoview-reviewers,MattN,agi
https://hg.mozilla.org/integration/autoland/rev/1152d253beb2
[2.0] Connect Gecko backend to GeckoView onLoginUsed API. r=MattN
https://hg.mozilla.org/integration/autoland/rev/282778a58d0b
[3.0] Add Login Storage onLoginUsed test. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/d0a06daef257
[4.0] Try to make top-level docs prettier. r=agi
https://hg.mozilla.org/integration/autoland/rev/6a2d19e7cdf2
[5.1] Update API changelog. r=geckoview-reviewers,agi

I think this caused

58:55.66 Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
58:57.06 /home/bclary/mozilla/builds/autoland/mozilla/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/LoginStorage.java:42: error: unexpected end tag: </p>
58:57.06  * </p>
58:57.06    ^
58:57.06 /home/bclary/mozilla/builds/autoland/mozilla/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/LoginStorage.java:312: error: reference not found
58:57.06      * Possible login entry field types for {@link onLoginUsed}.

(In reply to Bob Clary [:bc:] from comment #8)

I think this caused

58:55.66 Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf-8
58:57.06 /home/bclary/mozilla/builds/autoland/mozilla/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/LoginStorage.java:42: error: unexpected end tag: </p>
58:57.06  * </p>
58:57.06    ^
58:57.06 /home/bclary/mozilla/builds/autoland/mozilla/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/LoginStorage.java:312: error: reference not found
58:57.06      * Possible login entry field types for {@link onLoginUsed}.

Fixing in bug 1611474.

You need to log in before you can comment on or make changes to this bug.