161036 - "new browser" build configuration

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

This patch enables pulling and building of mozilla/toolkit and mozilla/browser
with a new configure option.  To use it, add the following lines to your
mozconfig file:

mk_add_options MOZ_PHOENIX=1
ac_add_options --enable-phoenix

The mk_add_options line makes client.mk pull the directories; the
ac_add_options line activates the configure option which causes MOZ_PHOENIX to
be #defined in the build and defined in the Makefiles.

Note that I didn't include the patch to "configure"; if you want to test this
patch you'll need to run "autoconf" in the mozilla directory after applying the
patch so that configure gets updated.

Comment 2

[David Hyatt]

Comment on attachment 93960 [details] [diff] [review]
patch

sr=hyatt

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 93960 [details] [diff] [review]
patch

As I posed to bryner on IRC:

Is this something for the general public to be working on? is it expected to
work? (I'm guessing no & no due to the use of "experimental" in the
description.)  if it's not for general use, then we shouldn't be adding
Yet-Another-Useless-Configure-Option for something that 5 people are going to
use.  stick with just using MOZ_PHOENIX

Comment 4

[Brian Ryner (not reading)]

Attachment: patch v2

took away the visible configure option

Comment 5

[Brian Ryner (not reading)]

Attachment: one more time

Comment 6

[Brendan Eich [:brendan]]

Hey, why the name change?  BROWSER is ambiguous in light of the existing,
built-by-default, xpfe-based browser; it also doesn't capture the directory
structure (toolkit as well as browser).  PHOENIX is _sui generis_, it doesn't
have to connote directory structure (no codename can), and it won't be confused
with the xpfe-based browser.

/be

Comment 7

[Brian Ryner (not reading)]

Comment on attachment 93979 [details] [diff] [review]
patch v2

Ok, let's go with this one then.

Comment 8

[hacker formerly known as [e-mail]]

Comment on attachment 93979 [details] [diff] [review]
patch v2

You might want to think about separating the phoenix dirs from the rest of the
gecko dirs to avoid the ordering issues and inadvertant intermodule
dependencies.  Other than that, r=cls

Comment 9

[Brian Ryner (not reading)]

This was checked in long ago and should have been closed.