"new browser" build configuration

RESOLVED FIXED

Status

SeaMonkey
Build Config
RESOLVED FIXED
16 years ago
7 years ago

People

(Reporter: Brian Ryner (not reading), Assigned: Brian Ryner (not reading))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

3.90 KB, patch
hacker formerly known as seawood@netscape.com
: review+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
 
(Assignee)

Comment 1

16 years ago
Created attachment 93960 [details] [diff] [review]
patch

This patch enables pulling and building of mozilla/toolkit and mozilla/browser
with a new configure option.  To use it, add the following lines to your
mozconfig file:

mk_add_options MOZ_PHOENIX=1
ac_add_options --enable-phoenix

The mk_add_options line makes client.mk pull the directories; the
ac_add_options line activates the configure option which causes MOZ_PHOENIX to
be #defined in the build and defined in the Makefiles.

Note that I didn't include the patch to "configure"; if you want to test this
patch you'll need to run "autoconf" in the mozilla directory after applying the
patch so that configure gets updated.

Comment 2

16 years ago
Comment on attachment 93960 [details] [diff] [review]
patch

sr=hyatt
Attachment #93960 - Flags: superreview+
Comment on attachment 93960 [details] [diff] [review]
patch

As I posed to bryner on IRC:

Is this something for the general public to be working on? is it expected to
work? (I'm guessing no & no due to the use of "experimental" in the
description.)  if it's not for general use, then we shouldn't be adding
Yet-Another-Useless-Configure-Option for something that 5 people are going to
use.  stick with just using MOZ_PHOENIX
Attachment #93960 - Flags: needs-work+
(Assignee)

Comment 4

16 years ago
Created attachment 93979 [details] [diff] [review]
patch v2

took away the visible configure option
Attachment #93960 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Summary: "Phoenix" build configuration → "new browser" build configuration
(Assignee)

Comment 5

16 years ago
Created attachment 94135 [details] [diff] [review]
one more time
Attachment #93979 - Attachment is obsolete: true
Hey, why the name change?  BROWSER is ambiguous in light of the existing,
built-by-default, xpfe-based browser; it also doesn't capture the directory
structure (toolkit as well as browser).  PHOENIX is _sui generis_, it doesn't
have to connote directory structure (no codename can), and it won't be confused
with the xpfe-based browser.

/be
(Assignee)

Comment 7

16 years ago
Comment on attachment 93979 [details] [diff] [review]
patch v2

Ok, let's go with this one then.
Attachment #93979 - Attachment is obsolete: false
(Assignee)

Updated

16 years ago
Attachment #94135 - Attachment is obsolete: true
Comment on attachment 93979 [details] [diff] [review]
patch v2

You might want to think about separating the phoenix dirs from the rest of the
gecko dirs to avoid the ordering issues and inadvertant intermodule
dependencies.  Other than that, r=cls
Attachment #93979 - Flags: review+
(Assignee)

Comment 9

15 years ago
This was checked in long ago and should have been closed.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.