Closed Bug 1610434 Opened 6 months ago Closed 6 months ago

Redundant space at the right end of Tab bar (when Menu bar is enabled)

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(thunderbird_esr68 fixed, thunderbird73 fixed)

RESOLVED FIXED
Thunderbird 74.0
Tracking Status
thunderbird_esr68 --- fixed
thunderbird73 --- fixed

People

(Reporter: bugs.sugs, Assigned: Paenglab)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.118 Safari/537.36

Actual results:

Redundant space at the right end of Tab bar (when Menu bar is enabled)

See the image.
v60 is OK.

(It's OK when mail.tabs.autoHide=True.)

Component: Toolbars and Tabs → Theme

This is Windows 7 only. The other Windows versions have bigger caption button and would overlap the calendar icons.

The patch hides the titlebar-placeholder when in drawInTitlebar and the menu bar is always shown.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9123127 - Flags: review?(alessandro)
Comment on attachment 9123127 [details] [diff] [review]
1610434-Win7-hide-titlebar-placeholder.patch

Review of attachment 9123127 [details] [diff] [review]:
-----------------------------------------------------------------

On the VM looks good, thanks for taking care of this.
A small indentation fix and this is good to go.

::: mail/themes/windows/mail/mailWindow1.css
@@ +145,5 @@
>  
> +@media (-moz-os-version: windows-win7) and (-moz-windows-glass: 0) {
> +  #messengerWindow[tabsintitlebar]
> +    #mail-toolbar-menubar2:not([autohide]) + #tabs-toolbar >
> +    .titlebar-placeholder {

Wrong indentation it seems.
Attachment #9123127 - Flags: review?(alessandro) → review+

(In reply to Alessandro Castellani (:aleca) from comment #2)

+@media (-moz-os-version: windows-win7) and (-moz-windows-glass: 0) {

  • #messengerWindow[tabsintitlebar]
  • #mail-toolbar-menubar2:not([autohide]) + #tabs-toolbar >
  • .titlebar-placeholder {

Wrong indentation it seems.

No, it's the second and third line of the selector. The indentation is to show it's not a second or third selector and they should be normally on the first line but go over the line lenght of 80 characters.

Attachment #9123127 - Flags: approval-comm-esr68?
Attachment #9123127 - Flags: approval-comm-beta?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/52ed40dc7d15
Windows 7: Hide the titlebar-placeholder when drawInTitletbar and non-autohide menu bar. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0
Attachment #9123127 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #9123127 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.