1610434 - Redundant space at the right end of Tab bar (when Menu bar is enabled)

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[BS]

Attachment: Thunderbird-68_TabBar_RightEnd_(ClassicTheme_ActiveWindowBorder_Top).png

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.118 Safari/537.36

Actual results:

Redundant space at the right end of Tab bar (when Menu bar is enabled)

See the image.
v60 is OK.

(It's OK when mail.tabs.autoHide=True.)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1610434-Win7-hide-titlebar-placeholder.patch

This is Windows 7 only. The other Windows versions have bigger caption button and would overlap the calendar icons.

The patch hides the titlebar-placeholder when in drawInTitlebar and the menu bar is always shown.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9123127 [details] [diff] [review]
1610434-Win7-hide-titlebar-placeholder.patch

Review of attachment 9123127 [details] [diff] [review]:
-----------------------------------------------------------------

On the VM looks good, thanks for taking care of this.
A small indentation fix and this is good to go.

::: mail/themes/windows/mail/mailWindow1.css
@@ +145,5 @@
>  
> +@media (-moz-os-version: windows-win7) and (-moz-windows-glass: 0) {
> +  #messengerWindow[tabsintitlebar]
> +    #mail-toolbar-menubar2:not([autohide]) + #tabs-toolbar >
> +    .titlebar-placeholder {

Wrong indentation it seems.

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani (:aleca) from comment #2)

+@media (-moz-os-version: windows-win7) and (-moz-windows-glass: 0) {

• #messengerWindow[tabsintitlebar]
• #mail-toolbar-menubar2:not([autohide]) + #tabs-toolbar >
• .titlebar-placeholder {

Wrong indentation it seems.

No, it's the second and third line of the selector. The indentation is to show it's not a second or third selector and they should be normally on the first line but go over the line lenght of 80 characters.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/52ed40dc7d15
Windows 7: Hide the titlebar-placeholder when drawInTitletbar and non-autohide menu bar. r=aleca

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 73.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f61f39e9e87e830b476ce6d696ccef37eeaf3c50

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 68.5.0:
https://hg.mozilla.org/releases/comm-esr68/rev/7a632a4f4e7f