Closed Bug 1610471 Opened 4 years ago Closed 4 years ago

[Static-Analysis] Some cli definitions are not passed in code as strings

Categories

(Developer Infrastructure :: Source Code Analysis, defect, P1)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1607204

People

(Reporter: andi, Assigned: andi)

References

(Regression)

Details

(Keywords: regression)

After the latest modification to compile_commands.json the inline definitions that should be considered as strings in code are broken and they are treated as identifiers this is because bug 1607204 eliminated double quotes from the inline parameters. As example can be seen here.

Can we backout the patch for bug 1607204?

Flags: needinfo?(rstewart)
Regressed by: 1607204
Summary: [Coverity] Some translation units fail that have defines passed through cli → [Static-Analysis] Some cli definitions are not pased in code as strings
Has Regression Range: --- → yes
Keywords: regression
Summary: [Static-Analysis] Some cli definitions are not pased in code as strings → [Static-Analysis] Some cli definitions are not passed in code as strings
No longer depends on: 1603433

I'll fix the regressing patch and re-land when it's approved.

Flags: needinfo?(rstewart)

What is the problematic case? Is it that: '-DAPP_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}' got some quotes stripped out of it along the way, or something else?

Yes, the quotes including the corresponding escaping chars are stripped out so the value is no longer a string literal but an identifier. The first example I could find is ‘ -DMOZ_APP_NAME=firefox’ where in the new context ‘firefox’ is no longer a string literal but an identifier.

Closing since this will be fix in Bug 1607204.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.