Closed Bug 1610474 Opened 5 months ago Closed 5 months ago

Make the editable menulist on Windows Classic prettier and don't hide the dropmarker when editable menulist is disabled

Categories

(Thunderbird :: Theme, task)

task
Not set
normal

Tracking

(thunderbird_esr68 fixed, thunderbird73 fixed)

RESOLVED FIXED
Thunderbird 74.0
Tracking Status
thunderbird_esr68 --- fixed
thunderbird73 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(4 files)

On Windows Classic the editable menulist looks a bit eroded.

And on Linux and Windows the dropmarker is hidden when the editable menulist is disabled. This makes the UI jumpy when the menulist enables/disables. Check the Event dialog and change the "All day Event" checkmark. We should only show the dropmarker disabled like in TB 68.

For the Windows issue I attach a screenshot.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9122005 - Flags: review?(alessandro)
Attachment #9122005 - Flags: approval-comm-beta?
Attached image editable-menulist.png

Screenshot with the before/after appearance. Windows 10 High Contrast is also a bit affected and has it's special styles in this patch.

When this gets a r+ I'll add a patch for TB 68 which has only the Windows display issue.

Comment on attachment 9122005 [details] [diff] [review]
1610474-dropmarker-disabled-menulist.patch

Review of attachment 9122005 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have a Windows machine to fully test this, but on Linux and macos the changes applied don't cause any regression.
I'm giving you an r+ based on the screenshot and the fact that the CSS changes make sense.
I don't know if you want to get a ui-r from a Windows user just to be extra sure.
Attachment #9122005 - Flags: review?(alessandro) → review+

The only Windows reviewer I know is Jörg and doesn't take reviews.

(In reply to Richard Marti (:Paenglab) from comment #4)

The only Windows reviewer I know is Jörg and doesn't take reviews.

I guess I know how I'm gonna spend the weekend then
Starts spinning up a VM

Patch for TB 68 addressing the Windows display issue.

Attachment #9122117 - Flags: approval-comm-esr68?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/81cf5d6780d7
Make the editable menulist on Windows Classic prettier and don't hide the dropmarker when editable menulist is disabled. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0
Attachment #9122005 - Flags: approval-comm-beta? → approval-comm-beta+
Attachment #9122117 - Flags: approval-comm-esr68? → approval-comm-esr68+

My menulists have gained an extra border on ESR, but not trunk. (Linux Mint)

Flags: needinfo?(richard.marti)

https://hg.mozilla.org/releases/comm-esr68/rev/4a04fcf97392 wasn't done from attachment 9122117 [details] [diff] [review]. My ESR patch had no changes for Linux. Removing the Linux changes should fix this.

Flags: needinfo?(richard.marti)
Flags: needinfo?(rob)

Thunderbird 68.5.0 (corrected uplift):
https://hg.mozilla.org/releases/comm-esr68/rev/32eb83fa3680

The comments are out of order, still figuring out bugherder.

Flags: needinfo?(rob)
You need to log in before you can comment on or make changes to this bug.