1610474 - Make the editable menulist on Windows Classic prettier and don't hide the dropmarker when editable menulist is disabled

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

On Windows Classic the editable menulist looks a bit eroded.

And on Linux and Windows the dropmarker is hidden when the editable menulist is disabled. This makes the UI jumpy when the menulist enables/disables. Check the Event dialog and change the "All day Event" checkmark. We should only show the dropmarker disabled like in TB 68.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1610474-dropmarker-disabled-menulist.patch

For the Windows issue I attach a screenshot.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: editable-menulist.png

Screenshot with the before/after appearance. Windows 10 High Contrast is also a bit affected and has it's special styles in this patch.

When this gets a r+ I'll add a patch for TB 68 which has only the Windows display issue.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9122005 [details] [diff] [review]
1610474-dropmarker-disabled-menulist.patch

Review of attachment 9122005 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have a Windows machine to fully test this, but on Linux and macos the changes applied don't cause any regression.
I'm giving you an r+ based on the screenshot and the fact that the CSS changes make sense.
I don't know if you want to get a ui-r from a Windows user just to be extra sure.

Comment 4

[Richard Marti (:Paenglab)]

The only Windows reviewer I know is Jörg and doesn't take reviews.

Comment 5

[Alessandro Castellani [:aleca]]

(In reply to Richard Marti (:Paenglab) from comment #4)

The only Windows reviewer I know is Jörg and doesn't take reviews.

I guess I know how I'm gonna spend the weekend then
Starts spinning up a VM

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1610474-dropmarker-disabled-menulist-ESR.patch

Patch for TB 68 addressing the Windows display issue.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/81cf5d6780d7
Make the editable menulist on Windows Classic prettier and don't hide the dropmarker when editable menulist is disabled. r=aleca

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 73.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f912e26e5a2091f0478afb3958c97a95e5607db7

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 68.5.0:
https://hg.mozilla.org/releases/comm-esr68/rev/4a04fcf97392

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Screenshot from 2020-02-08 21-11-58.png

My menulists have gained an extra border on ESR, but not trunk. (Linux Mint)

Comment 11

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/releases/comm-esr68/rev/4a04fcf97392 wasn't done from attachment 9122117 [details] [diff] [review]. My ESR patch had no changes for Linux. Removing the Linux changes should fix this.

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 68.5.0 (corrected uplift):
https://hg.mozilla.org/releases/comm-esr68/rev/32eb83fa3680

Comment 13

[Rob Lemley [:rjl]]

Backout bad uplift from 68.5.0:
https://hg.mozilla.org/releases/comm-esr68/rev/d35c709686c6

Comment 14

[Rob Lemley [:rjl]]

The comments are out of order, still figuring out bugherder.