Closed Bug 1610566 Opened 1 month ago Closed 1 month ago

Crash reporting code is assert()'ing when receiving a crash notification

Categories

(Toolkit :: Crash Reporting, defect, P3)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

I was investigating bug 1608932 and I noticed that the crash reporting code seems to be hitting an assertion when it receives an early notification of a content process crash. I'm opening this bug to investigate it because that shouldn't happen.

Priority: -- → P3

We're hitting this assertion which means we haven't written out a minidump. The error-handling along this code path sucks, it's time to overhaul it.

This affects desktop Firefox too. I'll fix the error-handling and add a warning to make the crash visible in the logs even though there's no minidump available.

Summary: Crash reporting code is assert()'ing when receiving a crash notification on GeckoView → Crash reporting code is assert()'ing when receiving a crash notification
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED

This also adds an explicit warning when this happens so that the child processes don't crash without leaving a trace.

Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f6e201853c8
Prevent child processes crashing before the exception-handler is in place from triggering an assertion in the parent process r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.