1610588 - AddRDMTask doesn't await tests before altering prefs

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[Brad Werth [:bradwerth]]

The AddRDMTask function is designed to run a test task twice, and modify the prefs between the task invocation. Unfortunately, the test setup code uses add_task, and doesn't await the completion of the task. This means that the prefs are changing mid-task or not at all.

Comment 1

[Brad Werth [:bradwerth]]

To clarify, the issue is that the calls to add_task are only ordered relative to each other. The existing code intercuts these calls will changes to prefs. If the changes to the prefs are also done with a call to add_task, then things should happen in the proper order.

Comment 2

[Brad Werth [:bradwerth]]

Attachment: Bug 1610588 Part 1: Make pref changes in AddRDMTask be ordered relative to the test functions themselves.

This patch more strictly orders the work in the AddRDMTask function, so that
the pref changes happen at the appropriate times relative to the tests.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1610588 Part 2: Disable failing tests for enabled browser UI

Depends on D60590

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47c35b06c9cf
Part 1: Make pref changes in AddRDMTask be ordered relative to the test functions themselves. r=mtigley
https://hg.mozilla.org/integration/autoland/rev/673452e098f1
Part 2: Disable failing tests for enabled browser UI r=mtigley

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/47c35b06c9cf
https://hg.mozilla.org/mozilla-central/rev/673452e098f1