Closed Bug 1610669 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21326 - Use assert_precondition in ElementTiming/LargestContentfulPaint

Categories

(Core :: Performance, task, P4)

Product:
Core
Component:
Performance
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21326 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21326
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

Use assert_precondition in ElementTiming/LargestContentfulPaint

This CL replaces assert_unreached for assert_precondition for the API
existence checks in the ElementTiming and LargestContentfulPaint WPTs.

Change-Id: Icd2ff3e045835cf4c46a370a384455143a717308
Reviewed-on: https://chromium-review.googlesource.com/2013863
WPT-Export-Revision: 38b1d51889665d9ec8191ab8159f02a456b58e37

PR 21326 applied with additional changes from upstream: 606da537b95e54f4f1d53774ec03634f5902bc01
Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 101 tests and 1 subtests

Status Summary

Firefox

OK : 60
PASS : 41
PRECONDITION_FAILED: 60

Chrome

OK : 60
PASS : 60

Safari

OK : 60
PRECONDITION_FAILED: 60

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/largest-contentful-paint/first-letter-background.html
Largest Contentful Paint: first-letter is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-TAO.sub.html
Cross-origin elements with valid TAO have correct renderTime, with invalid TAO have renderTime set to 0.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/expanded-image.html
Largest Contentful Paint: |size| attribute is bounded by intrinsic size.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/cross-origin-image.sub.html
Cross-origin image is observable, with renderTime equal to 0.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/iframe-content-not-observed.html
Element in child iframe is not observed, even if same-origin.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/element-only-when-fully-active.html
Only expose element attribute for fully active documents: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/rectangular-image.html
Element with rectangular image has correct rect and instrinsic size.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/video-poster.html
Able to observe a video's poster image.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/larger-text.html
Largest Contentful Paint: largest text is reported.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/first-letter-background.html
Element with elementtiming attribute and background image in first-letter is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-with-rotation.html
Image intersectionRect is affected by rotation, but not its intrinsic size.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-empty-attribute.html
Able to observe image and text with empty elementtiming attribute.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/progressively-loaded-image.html
Element Timing: image render timestamp occurs after it is fully loaded.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/buffer-before-onload.html
Element Timing: image loads before onload available from buffered flag.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-child-element.html
Element in child iframe is not observed, even if same-origin.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-background-image.html
Element with elementtiming attribute and background image is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/background-image-multiple-elements.html
Background image affecting various elements is observed.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-video-poster.html
Able to observe a video's poster image.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/redirects-tao-star.html
Cross-origin image without TAO should not have its renderTime set, with full TAO it should.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/invisible-images.html
Images with opacity: 0, visibility: hidden, or display: none are not observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-multiple-images.html
PerformanceObserver can observe multiple image elements.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/repeated-image.html
Repeated image produces different timestamps.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/background-image-stretched.html
Element with background image shows correct image size.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/image-src-change.html
Largest Contentful Paint: changing src causes a new entry to be dispatched.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-not-fully-visible.html
The intersectionRect of an img element overflowing is computed correctly: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/larger-image.html
Largest Contentful Paint: largest image is reported.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/loadTime-after-appendChild.html
Image loadTime occurs after appendChild is called.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-clipped-svg.html
Able to observe svg image.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/observe-image.html
Same-origin image is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-src-change.html
Element Timing: changing src causes a new entry to be dispatched.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/scroll-to-text.html
Paragraph with elementtiming attribute is observed even when not initially visible.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/disconnect-image.html
Disconnected elements have null as their |element| attribute.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/contracted-image.html
Largest Contentful Paint: |size| attribute is bounded by display size.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-data-uri.html
Inline image is observable via Element Timing.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/toJSON.html
Test toJSON() in PerformanceElementTiming.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/observe-after-untrusted-scroll.html
Same-origin image after a JS initiated scroll event is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-shadow-image.html
Image in shadow tree with elementtiming attribute is not observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-rect-iframe.html
Element Timing entry in iframe has coordinates relative to the iframe.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/invisible-images.html
Images with opacity: 0, visibility: hidden, or display: none are not observable by LargestContentfulPaint.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-shadow-text.html
Text in shadow tree with elementtiming attribute is not observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-svg-image.html
Able to observe svg image.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-text.html
Paragraph with elementtiming attribute is observed.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/toJSON.html
Test toJSON() in LargestContentfulPaint.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/background-image-data-uri.html
Element with elementtiming attribute and inline background image is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/cross-origin-element.sub.html
Cross-origin image element is NOT observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-carousel.html
Entries for elements within an image carousel are dispatched when the elements are redrawn.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/images-repeated-resource.html
Elements with elementtiming and same src are observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/first-paint-equals-lcp-text.html
FCP and LCP are the same when there is a single text element in the page.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/observe-elementtiming.html
Element with elementtiming attribute is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/multiple-background-images.html
Element with two background images receives both.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/retrievability.html
Element Timing entries are not accessible via performance.getEntries*: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/cross-origin-iframe-element.sub.html
Element from cross origin iframe is NOT observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-with-css-scale.html
Image intersectionRect is affected by scaling, but not its intrinsic size.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/css-generated-text.html
Generated text content is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/image-not-added.html
Image which is not added to DOM tree is not observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/fixed-id-identifier.html
PerformanceElementTiming id and identifier do not change when Element changes.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/text-with-display-style.html
Text with display style is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/element-timing/buffered-flag.html
Element Timing entries are observable via buffered flag.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/text-with-display-style.html
Text with display style is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/largest-contentful-paint/observe-text.html
Element with elementtiming attribute is observable.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b3542da8e5f
[wpt PR 21326] - Use assert_precondition in ElementTiming/LargestContentfulPaint, a=testonly
https://hg.mozilla.org/integration/autoland/rev/18bc060f05e7
[wpt PR 21326] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3b3542da8e5f
https://hg.mozilla.org/mozilla-central/rev/18bc060f05e7

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.