1610702 - Support ResizeToFit() for non-pod type in mozilla::Vector

Status: RESOLVED FIXED

(Core :: MFBT, enhancement, P3)

Description

[Boris Chiou [:boris]]

See https://phabricator.services.mozilla.com/D60045#inline-367732, we would like to use Vector as the container for StyleTransformOperation and convert it into StyleOwnSliced directly (without any copy). For now, we add an assertion if its capacity is different from its length to make sure we don't leak.

However, the best way is to support something like ResizeToFit() for non-POD types, and then we can drop the assertion.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Probably shrinkStorageToFit or something like that?

And this is not really about leaking, but about Rust allocator requiring the capacity (though I believe mozalloc doesn't) and thus making boxed slices just length == capacity, and OwnedSlice maintaining that. Though it'd be useful more generally I bet.

Comment 2

[Boris Chiou [:boris]]

OK. I see. Thanks for the clarification.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1610702 - Generalize Vector::podResizeToFit into Vector::shrinkStorageToFit(). r=froydnj

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5d0ed5f15d4
Generalize Vector::podResizeToFit into Vector::shrinkStorageToFit(). r=froydnj

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f5d0ed5f15d4